-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local Alertmanager MVP #3252
Local Alertmanager MVP #3252
Conversation
1414394
to
4fec7f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3252 +/- ##
===========================================
- Coverage 91.51% 91.48% -0.04%
===========================================
Files 297 297
Lines 8416 8433 +17
Branches 608 611 +3
===========================================
+ Hits 7702 7715 +13
- Misses 604 605 +1
- Partials 110 113 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
…into 3242-local-alert-manager-new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and received email! Exciting 👍
receivers: | ||
- name: 'admin-team-emails' | ||
email_configs: | ||
- to: '[email protected]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please hide email recipients on lines 67 and 71. additionally, @ttran-hub and I should be recipients when this is ported over to cloud.gov prod env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will get this templated out. I will also discuss the most convenient way to access this info so that it can be imputed upon deployment with the dev team in OH today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ADPennington just wanted to let you know I put the email template resolution in this PR since it deploys alertmanager. |
Summary of Changes
Logs
dashboard to also display uptime/availabilityPull request closes Local Alertmanager #3242
How to Test
up
everything. You need to add your email (instead of mine) and a SENDGRID_API_KEY to alertmanager.yml.alertmanager.yml
replace{{ sendgrid_api_key }}
with a valid api key.alertmanager.yml
replace my emails with your email(s).alertmanager
container logs and verify no new alerts are firing (note you could see a message like:level=debug component=dispatcher msg="Received alert" alert="Local Backend Down[7649f89][active]"
initially and that it is immediately resolved after:level=debug component=dispatcher msg="Received alert" alert="Local Backend Down[7649f89][resolved]"
. This happens because of some tight timing tolerances. You will not get an email for this which is expected.alertmanager
is NOT firing any new alerts.postgres
orweb
or both containers and watchalertmanager
start firing alerts. After the alert(s) have fired for at least 1 minute you will receive emails for the alerts. You will not receive another email for the alert for another 5 minutesalertmanager
marks the firing alert(s) as resolved.Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):