forked from HHS/TANF-app
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3014 - Outdated submissions banner #3231
Merged
Merged
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
3357e84
show banner and hide errors if file submitted before 5/31/2024
jtimpe 14cc136
add tests
jtimpe 7ee53a6
more descriptive param names
jtimpe 4e0b1bb
Merge branch 'develop' into 3014-outdated-submissions-banner
jtimpe b1a89bd
Merge branch 'develop' into 3014-outdated-submissions-banner
ADPennington f305d2a
Merge branch 'develop' into 3014-outdated-submissions-banner
ADPennington b098d05
include reparse in data files api response
jtimpe a1ffb0d
check reparse finished_at if submission outdated
jtimpe 82d0bb6
lint, clean up comments
jtimpe 3eb696f
Merge branch 'develop' into 3014-outdated-submissions-banner
jtimpe d7291fb
Merge branch 'develop' into 3014-outdated-submissions-banner
ADPennington 9ff75dc
Merge branch 'develop' into 3014-outdated-submissions-banner
ADPennington eb8f661
move outdated submission processing to backend, make configurable
jtimpe cc63781
revert reparse_file_metas change
jtimpe 11fc447
add reprocessed indicators to submission history tables
jtimpe 15dafb6
Merge branch 'develop' into 3014-outdated-submissions-banner
jtimpe caf1c8a
update outdated error report language
jtimpe 607b51e
Merge branch 'develop' into 3014-outdated-submissions-banner
jtimpe b0d3232
update language
jtimpe 825f5b3
Merge branch 'develop' into 3014-outdated-submissions-banner
jtimpe 18d7363
fix date compare
jtimpe d988e2d
remove old submissions banner, column text, serializer data
jtimpe a098543
rm tests
jtimpe 28d4b78
rm unused
jtimpe 4b278d1
rm unused properties, rename used property
jtimpe 11abfb5
Merge branch 'develop' into 3014-outdated-submissions-banner
jtimpe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,10 @@ import { useDispatch } from 'react-redux' | |
import { | ||
SubmissionSummaryStatusIcon, | ||
formatDate, | ||
hasReparsed, | ||
getReprocessedDate, | ||
downloadFile, | ||
downloadErrorReport, | ||
getErrorReportStatus, | ||
} from './helpers' | ||
|
||
const MonthSubRow = ({ data }) => | ||
|
@@ -24,17 +26,13 @@ const MonthSubRow = ({ data }) => | |
|
||
const CaseAggregatesRow = ({ file }) => { | ||
const dispatch = useDispatch() | ||
const errorFileName = `${file.year}-${file.quarter}-${file.section}` | ||
|
||
return ( | ||
<> | ||
<tr> | ||
<th scope="rowgroup" rowSpan={3}> | ||
{formatDate(file.createdAt)} | ||
</th> | ||
|
||
<th scope="rowgroup" rowSpan={3}> | ||
{file.submittedBy} | ||
{formatDate(file.createdAt) + ' by ' + file.submittedBy} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{hasReparsed(file) && <></>} | ||
</th> | ||
|
||
<th scope="rowgroup" rowSpan={3}> | ||
|
@@ -64,22 +62,7 @@ const CaseAggregatesRow = ({ file }) => { | |
</th> | ||
|
||
<th scope="rowgroup" rowSpan={3}> | ||
{file.summary && | ||
file.summary.status && | ||
file.summary.status !== 'Pending' ? ( | ||
file.hasError > 0 ? ( | ||
<button | ||
className="section-download" | ||
onClick={() => downloadErrorReport(file, errorFileName)} | ||
> | ||
{errorFileName}.xlsx | ||
</button> | ||
) : ( | ||
'No Errors' | ||
) | ||
) : ( | ||
'Pending' | ||
)} | ||
{getErrorReportStatus(file)} | ||
</th> | ||
</tr> | ||
<tr> | ||
|
@@ -99,9 +82,6 @@ export const CaseAggregatesTable = ({ files }) => ( | |
<th scope="col" rowSpan={2}> | ||
Submitted On | ||
</th> | ||
<th scope="col" rowSpan={2}> | ||
Submitted By | ||
</th> | ||
<th scope="col" rowSpan={2}> | ||
File Name | ||
</th> | ||
|
1 change: 1 addition & 0 deletions
1
tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,10 @@ import { useDispatch } from 'react-redux' | |
import { | ||
SubmissionSummaryStatusIcon, | ||
formatDate, | ||
hasReparsed, | ||
getReprocessedDate, | ||
downloadFile, | ||
downloadErrorReport, | ||
getErrorReportStatus, | ||
} from './helpers' | ||
|
||
const MonthSubRow = ({ data }) => | ||
|
@@ -22,17 +24,13 @@ const MonthSubRow = ({ data }) => | |
|
||
const TotalAggregatesRow = ({ file }) => { | ||
const dispatch = useDispatch() | ||
const errorFileName = `${file.year}-${file.quarter}-${file.section}` | ||
|
||
return ( | ||
<> | ||
<tr> | ||
<th scope="rowgroup" rowSpan={3}> | ||
{formatDate(file.createdAt)} | ||
</th> | ||
|
||
<th scope="rowgroup" rowSpan={3}> | ||
{file.submittedBy} | ||
{formatDate(file.createdAt) + ' by ' + file.submittedBy} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{hasReparsed(file) && <></>} | ||
</th> | ||
|
||
<th scope="rowgroup" rowSpan={3}> | ||
|
@@ -58,22 +56,7 @@ const TotalAggregatesRow = ({ file }) => { | |
</th> | ||
|
||
<th scope="rowgroup" rowSpan={3}> | ||
{file.summary && | ||
file.summary.status && | ||
file.summary.status !== 'Pending' ? ( | ||
file.hasError > 0 ? ( | ||
<button | ||
className="section-download" | ||
onClick={() => downloadErrorReport(file, errorFileName)} | ||
> | ||
{errorFileName}.xlsx | ||
</button> | ||
) : ( | ||
'No Errors' | ||
) | ||
) : ( | ||
'Pending' | ||
)} | ||
{getErrorReportStatus(file)} | ||
</th> | ||
</tr> | ||
<tr> | ||
|
@@ -93,9 +76,6 @@ export const TotalAggregatesTable = ({ files }) => ( | |
<th scope="col" rowSpan={2}> | ||
Submitted On | ||
</th> | ||
<th scope="col" rowSpan={2}> | ||
Submitted By | ||
</th> | ||
<th scope="col" rowSpan={2}> | ||
File Name | ||
</th> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️