Sentry ADR #3206
Merged
Sentry ADR #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…whole queryset into memory
- Added extra console logging - changed log level on frequent exception
- Add tests
- Update all files done logic - Add new test for sequential execution
…ch/TANF-app into 3170-reparse-memory-mgmt
- change order
- Update test to create fields with correct type
…ch/TANF-app into 3170-reparse-memory-mgmt
- add tests for meta model methods
…nstead aggregate errors and log a warning message for the user.
…ch/TANF-app into 3170-reparse-memory-mgmt
- Give Prod at least 500GB
Reparse Memory Management
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## doc/3199-monitoring-adr #3206 +/- ##
===========================================================
+ Coverage 91.40% 92.66% +1.25%
===========================================================
Files 289 47 -242
Lines 7997 1009 -6988
Branches 746 169 -577
===========================================================
- Hits 7310 935 -6375
+ Misses 581 42 -539
+ Partials 106 32 -74
Flags with carried forward coverage won't be shown. Click here to find out more. see 242 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
andrew-jameson
changed the base branch from
develop
to
doc/3199-monitoring-adr
andrew-jameson
added a commit
that referenced
this pull request
Oct 28, 2024
* first steps on ADR * First pass on monitoring ADR * Sentry ADR (#3206) * - Updated method to batch delete records in elastic to avoid pulling whole queryset into memory * - Instantiate document once * - Updated clean and reparse to not load entire queryset into memory - Added extra console logging - changed log level on frequent exception * - Update names of functions - Add tests * - Update sequential function to return boolean to allow testing - Update all files done logic - Add new test for sequential execution * - new indices * - linting * - Added tests for most exception paths * -linting * - Adding refresh * - testing not duplicating container * - revert test change - change order * - remove param * - Add missing tests * - adding test * - Add remaining tests * - Add more debug logging * - running only failing test * - more debugging * - backend only * - remove test_reparse only * - Reset settings after parsing * - update file * - Update factories to use the correct types for fields - Update test to create fields with correct type * - paremetrize test * - revert debugging changes * - Add tests for more coverage * - linting * - UPdate logic for setting reparse to finished - add tests for meta model methods * - linting * - add basic tests for db backup * - remove mock * - add main routine test for backup * - linting * - Added comment for posterity * - Update reparse to not fail/exit when elastic throws index update. instead aggregate errors and log a warning message for the user. * - update terraform for testing * - Update terraform based on cloud.gov response - Give Prod at least 500GB * Sentry ADR --------- Co-authored-by: Eric Lipe <[email protected]> Co-authored-by: Eric Lipe <[email protected]> Co-authored-by: Alex P. <[email protected]> * Incorporating Sentry, split into two buckets. * Updated boundary diagram * New env diagram * Verbiage update to markdown * Latest diagram revision * Apply suggestions from code review Co-authored-by: Alex P. <[email protected]> * - small grammar and wording changes * Update docs/Technical-Documentation/Architecture-Decision-Record/022-app-monitoring.md Co-authored-by: Alex P. <[email protected]> * Updated diagram for better repr around ATO boundary --------- Co-authored-by: andrew-jameson <[email protected]> Co-authored-by: raftmsohani <[email protected]> Co-authored-by: Eric Lipe <[email protected]> Co-authored-by: Eric Lipe <[email protected]> Co-authored-by: Alex P. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Provide a brief summary of changes
Pull request closes #_
How to Test
List the steps to test the PR
These steps are generic, please adjust as necessary.
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlichand/oradpenningtonconfirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Reportcomment in PR)CodeCov Reportcomment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjollyandttran-hubusing Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):