Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reparse Memory Management #3172
Reparse Memory Management #3172
Changes from 3 commits
cc536b5
a27086c
6f2105f
223bc40
a8093e5
f34b014
ccd1816
d96f455
b1f71dd
5621f7f
9a03ff3
778c827
4d2ee69
d8a3b44
fa77bac
01dc2c3
876260c
76624fc
644703f
09bf83d
9fe3d1c
9421869
d456c8b
f408833
a3aa2f4
9e28a66
d7b543a
e1bfce3
3f89673
dc55e3e
c3002e0
4075194
96372d8
830b6d2
51ec731
b9cb34e
a85b232
76fa734
0dfb37e
16c1e11
0fd06c2
8187285
e752589
23924fb
93bd544
0543f29
f0a6c55
a981311
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
_raw_delete()
fast enough that we don't need a paginator? Does PG have an optimized solution here but not above?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason we don't need to use pagination on the deletes is because nothing is pulled into main memory. Every operation up to that point was being lazy evaluated. When we tell Django to
_raw_delete
it lets the DB engine execute the query and only returns the number of rows that were deleted. As opposed to returning adict
of model items that were deleted.