Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3106 reparse django action #3167
3106 reparse django action #3167
Changes from 70 commits
2753507
f912d6b
b79cbb1
11b411e
1ca33a6
e5b9371
4a3a169
f810633
bc050cf
16bfbce
3fa6d7a
f91fc46
6c0cc70
3f7690c
fb6ecb7
198b98a
c61b298
b3504b9
e87808c
16ecfdb
d59af03
e1a3bbc
d3fd407
2237686
778f706
a5737b4
8e94085
7fa47a8
dd6d85e
1463ea4
152d439
d3deddf
f78e5ae
a54f14a
2b75af8
626087f
38d50f5
5e6c89c
ed965ac
95b6ebd
1c19e87
98bd857
e09ce5d
e100f6d
3daebc5
4f28656
f1c22f4
6ca4da4
f3a3959
4945d32
d1fb4d6
6e723e0
bf2d288
a1c4631
4d6dcb4
cfc919b
3355b97
0820878
a20b740
98861c6
f758860
b9128dd
1681c96
59cf447
b8af66f
72119a8
b08f324
5c8220e
0b2b3f2
8f8a575
959ee4e
8fbf08a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: if not admin, then the reparse command is not shown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
evidence below that digit cant reparse or view reparse model cc: @ttran-hub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user.is_in_group()
oruser.is_ofa_sys_admin
(modified to accept both)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is then it will do two queries instead of one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might it be worth appending Developer to this list or do you guys change roles frequently for your testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I change my role from time to time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i tested this new option on a subset of files with this command:
python manage.py clean_and_reparse -f "1215,1030,2246,1807,1737,1826,1044"
and this immediately triggered the reparsing process and did not prompt me to confirm that I wanted to reparse X number of files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i expected something like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per Jan:
evidence here