-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-parse Command #3041
Re-parse Command #3041
Conversation
- Updated reparse command to leverage backup/restore command
…3004-clean-and-reparse-cmd
- Added final backup check just in case - Added password to cmd shell context - Updated index naming convention and logging
…Django command. - Added continue message to repasrse command - lint
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3041 +/- ##
===========================================
- Coverage 93.04% 93.01% -0.03%
===========================================
Files 277 277
Lines 7420 7421 +1
Branches 657 660 +3
===========================================
- Hits 6904 6903 -1
- Misses 414 415 +1
- Partials 102 103 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Step 4 in the 'How to Test' section needs a little more verbosity and usage examples for QASP unless a markdown document is planned. |
tdrs-backend/tdpservice/search_indexes/management/commands/clean_and_reparse.py
Show resolved
Hide resolved
tdrs-backend/tdpservice/search_indexes/management/commands/clean_and_reparse.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tried a couple of edge cases and it worked. Great Work! 🥇
tdrs-frontend/.env
Outdated
@@ -37,7 +37,8 @@ REACT_APP_DEBOUNCE_TIME=30000 | |||
REACT_APP_EVENT_THROTTLE_TIME=60000 | |||
|
|||
# Enable the Kibana tab for dev purposes. | |||
# REACT_APP_DEV_KIBANA=true | |||
# TODO: Comment once done developing | |||
REACT_APP_DEV_KIBANA=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to comment out once qasp-approved.
- Fixed minor logic error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great @elipe17 🚀 thank you!
Notes for awareness and ticket priority-setting @robgendron @lfrohlich @ttran-hub:
-
this feature currently operates from CLI. This PR includes documentation for how to run these commands from GFE. Sys admins will pair on this task, for now, but Re-Parse Django Action #3106 will track feasibility work for being able to trigger re-parsing from the TDP interfaces.
-
current options facilitate re-parsing primarily by fiscal period, but Additional datafile filters #3108 will track more options to further customize which files to re-parse (e.g. all tribes, all active files for Washington state, latest version of a file, etc. )
-
when the re-parsing command is run, the original submission details (e.g. data submitter, data file) is retained, but the submission date is overwritten. [Re-parse command] Retain original submission date when command runs #3107 will address this.
-
the dev team recommends that we hold off on executing this command until Re-parse Meta Model #3064 and Spike - Guarantee Sequential Execution of Re-parse Command #3065 are implemented, which will help ensure that sys admins has more visibility into the status of the re-parsing process to help ensure that the db is in a stable state.
Summary of Changes
Pull request closes Implement (small) data lifecycle (backup/archive ES) #3004
How to Test
clean_and_reparse
Django command a myriad of times with different values for the parameters.Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):