-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2677 - Add sendgrid api key to deploy-backend #3019
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3019 +/- ##
===========================================
- Coverage 93.11% 92.96% -0.15%
===========================================
Files 273 276 +3
Lines 7087 7140 +53
Branches 598 603 +5
===========================================
+ Hits 6599 6638 +39
- Misses 395 407 +12
- Partials 93 95 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked CirCI and the Raft env and verified the var was there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Pull request closes #2677
How to Test
SENDGRID_API_KEY
(or verify/modify the existing value). If you change it, you'll be able to see the change in the final steptdrs-backend-{env}
environment variables in cloud.gov, verify the value from circleci is in place forSENDGRID_API_KEY
Proof from my test
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
SENDGRID_API_KEY
todeploy-backend.sh
to be managed by circlecilfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):