forked from HHS/TANF-app
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2133 tribe discoverability #2999
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
43cd8c5
add radio button for jurisdiction type
jtimpe 117c60f
add tests
jtimpe 7c0f4b1
Merge branch 'develop' into 2133-tribe-discoverability
jtimpe c356f99
Merge branch 'develop' into 2133-tribe-discoverability
jtimpe 14555bb
Merge branch 'develop' into 2133-tribe-discoverability
jtimpe 2654f3c
Merge branch 'develop' into 2133-tribe-discoverability
jtimpe c1e2b70
update error string
jtimpe eb752bd
fix tests
jtimpe 32abfe9
Merge branch 'develop' into 2133-tribe-discoverability
ADPennington 14ca954
don't show jurisdiction type for acf users
jtimpe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
export const toTitleCase = (str) => | ||
str && | ||
str.replace( | ||
/\w\S*/g, | ||
(txt) => txt.charAt(0).toUpperCase() + txt.substr(1).toLowerCase() | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import { toTitleCase } from './stringUtils' | ||
|
||
describe('toTitleCase', () => { | ||
it.each([ | ||
['test me', 'Test Me'], | ||
['tribe', 'Tribe'], | ||
[' i like peanuts ', ' I Like Peanuts '], | ||
['jeffrey wuz 123here', 'Jeffrey Wuz 123here'], | ||
['', ''], | ||
[null, null], | ||
])('Capitalizes first char of each word', (original, expected) => { | ||
expect(toTitleCase(original)).toEqual(expected) | ||
}) | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtimpe looks like we are undoing the work implemented here to display the STT combobox only for those who sign-in via login.gov. When ACF users request access they do not see the combobox because they are associated with the federal government. in the screenshot below s=staging, q = qasp. i included the email that acf user receives which reflects the missing STT option (this is to be addressed in a future ticket).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thank you. i added the conditional around the Jurisdiction Type selection