2897 finalized reporting language

tdrs-backend/tdpservice/data_files/test/test_api.py

@@ -96,23 +96,23 @@ def assert_error_report_tanf_file_content_matches_with_friendly_names(response):
         """Assert the error report file contents match expected with friendly names."""
         ws = DataFileAPITestBase.get_spreadsheet(response)
 
-        COL_ERROR_MESSAGE = 5
+        COL_ERROR_MESSAGE = 4
 
-        assert ws.cell(row=1, column=1).value == "Error reporting in TDP is still in development.We'll" \
-            + " be in touch when it's ready to use!For now please refer to the reports you receive via email"
-        assert ws.cell(row=5, column=COL_ERROR_MESSAGE).value == "if cash amount :873 validator1 passed" \
+        assert ws.cell(row=1, column=1).value == "Please refer to the most recent versions of the coding " \
+            + "instructions (linked below) when looking up items and allowable values during the data revision process"
+        assert ws.cell(row=8, column=COL_ERROR_MESSAGE).value == "if cash amount :873 validator1 passed" \
             + " then number of months T1: 0 is not larger than 0."
 
     @staticmethod
     def assert_error_report_ssp_file_content_matches_with_friendly_names(response):
         """Assert the error report file contents match expected with friendly names."""
         ws = DataFileAPITestBase.get_spreadsheet(response)
 
-        COL_ERROR_MESSAGE = 5
+        COL_ERROR_MESSAGE = 4
 
-        assert ws.cell(row=1, column=1).value == "Error reporting in TDP is still in development.We'll" \
-            + " be in touch when it's ready to use!For now please refer to the reports you receive via email"
-        assert ws.cell(row=4, column=COL_ERROR_MESSAGE).value == "TRAILER record length is 15 characters " + \
+        assert ws.cell(row=1, column=1).value == "Please refer to the most recent versions of the coding " \
+            + "instructions (linked below) when looking up items and allowable values during the data revision process"
+        assert ws.cell(row=7, column=COL_ERROR_MESSAGE).value == "TRAILER record length is 15 characters " + \
             "but must be 23."
 
     @staticmethod
@@ -128,11 +128,11 @@ def assert_error_report_file_content_matches_without_friendly_names(response):
         wb = openpyxl.load_workbook('mycls.xlsx')
         ws = wb.get_sheet_by_name('Sheet1')
 
-        COL_ERROR_MESSAGE = 5
+        COL_ERROR_MESSAGE = 4
 
-        assert ws.cell(row=1, column=1).value == "Error reporting in TDP is still in development.We'll" \
-            + " be in touch when it's ready to use!For now please refer to the reports you receive via email"
-        assert ws.cell(row=5, column=COL_ERROR_MESSAGE).value == ("if CASH_AMOUNT :873 validator1 passed then "
+        assert ws.cell(row=1, column=1).value == "Please refer to the most recent versions of the coding " \
+            + "instructions (linked below) when looking up items and allowable values during the data revision process"
+        assert ws.cell(row=8, column=COL_ERROR_MESSAGE).value == ("if CASH_AMOUNT :873 validator1 passed then "
                                                                   "NBR_MONTHS T1: 0 is not larger than 0.")
 
     @staticmethod

tdrs-backend/tdpservice/data_files/util.py

@@ -36,27 +36,51 @@ def format_error_msg(x):
     output = BytesIO()
     workbook = xlsxwriter.Workbook(output)
     worksheet = workbook.add_worksheet()
+
     report_columns = [
         ('case_number', lambda x: x['case_number']),
         ('year', lambda x: str(x['rpt_month_year'])[0:4] if x['rpt_month_year'] else None),
         ('month', lambda x: calendar.month_name[
             int(str(x['rpt_month_year'])[4:])
             ] if x['rpt_month_year'] else None),
-        ('error_type', lambda x: x['error_type']),
         ('error_message', lambda x: format_error_msg(chk(x))),
         ('item_number', lambda x: x['item_number']),
         ('item_name', lambda x: ','.join([i for i in chk(x)['fields_json']['friendly_name'].values()])),
         ('internal_variable_name', lambda x: ','.join([i for i in chk(x)['fields_json']['friendly_name'].keys()])),
         ('row_number', lambda x: x['row_number']),
-        ('column_number', lambda x: x['column_number'])
     ]
 
     # write beta banner
-    worksheet.write(row, col,
-                    "Error reporting in TDP is still in development." +
-                    "We'll be in touch when it's ready to use!" +
-                    "For now please refer to the reports you receive via email")
+    worksheet.write(
+        row, col,
+        "Please refer to the most recent versions of the coding " +
+        "instructions (linked below) when looking up items " +
+        "and allowable values during the data revision process"
+    )
+
+    row, col = 1, 0
+    worksheet.write_url(
+        row, col,
+        'https://www.acf.hhs.gov/ofa/policy-guidance/tribal-tanf-data-coding-instructions',
+        string='For Tribal TANF data reports: Tribal TANF Instructions',
+    )
+
     row, col = 2, 0
+    worksheet.write_url(
+        row, col,
+        'https://www.acf.hhs.gov/ofa/policy-guidance/acf-ofa-pi-23-04',
+        string='For TANF and SSP-MOE data reports: TANF / SSP-MOE (ACF-199 / ACF-209) Instructions'
+    )
+
+    row, col = 3, 0
+    worksheet.write_url(
+        row, col,
+        'https://tdp-project-updates.app.cloud.gov/knowledge-center/viewing-error-reports.html',
+        string='Visit the Knowledge Center for further guidance on reviewing error reports'
+    )
+
+    row, col = 5, 0
+
     # write csv header
     bold = workbook.add_format({'bold': True})
 
@@ -68,7 +92,7 @@ def format_header(header_list: list):
     [worksheet.write(row, col, format_header(key[0]), bold) for col, key in enumerate(report_columns)]
 
     [
-        worksheet.write(row + 3, col, key[1](data_i)) for col, key in enumerate(report_columns)
+        worksheet.write(row + 6, col, key[1](data_i)) for col, key in enumerate(report_columns)
         for row, data_i in enumerate(data)
     ]
 

tdrs-frontend/src/components/SubmissionHistory/CaseAggregatesTable.jsx

@@ -121,7 +121,7 @@ export const CaseAggregatesTable = ({ files }) => (
           Status
         </th>
         <th scope="col" rowSpan={2}>
-          Error Reports (In development)
+          Error Reports
         </th>
       </tr>
     </thead>

tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.jsx

@@ -72,17 +72,31 @@ const SubmissionHistory = ({ filterValues }) => {
   }, [hasFetchedFiles, files, dispatch, filterValues])
 
   return (
-    <div>
-      {fileUploadSections.map((section, index) => (
-        <SectionSubmissionHistory
-          key={section}
-          section={index + 1}
-          label={section}
-          filterValues={filterValues}
-          files={files.filter((f) => f.section.includes(section))}
-        />
-      ))}
-    </div>
+    <>
+      <div className="margin-top-2">
+        <a
+          className="usa-link"
+          href="https://tdp-project-updates.app.cloud.gov/knowledge-center/viewing-error-reports.html"
+          target="_blank"
+          aria-label="Knowledge Center error reports guidance"
+          rel="noreferrer"
+        >
+          Visit the Knowledge Center for further guidance on reviewing error
+          reports
+        </a>
+      </div>
+      <div>
+        {fileUploadSections.map((section, index) => (
+          <SectionSubmissionHistory
+            key={section}
+            section={index + 1}
+            label={section}
+            filterValues={filterValues}
+            files={files.filter((f) => f.section.includes(section))}
+          />
+        ))}
+      </div>
+    </>
   )
 }
 

tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.test.js

@@ -241,9 +241,7 @@ describe('SubmissionHistory', () => {
     expect(screen.queryByText('test5.txt')).not.toBeInTheDocument()
     expect(screen.queryByText('test6.txt')).toBeInTheDocument()
 
-    expect(
-      screen.queryByText('Error Reports (In development)')
-    ).toBeInTheDocument()
+    expect(screen.queryByText('Error Reports')).toBeInTheDocument()
   })
 
   it('Shows SSP results when SSP-MOE file type selected', () => {

tdrs-frontend/src/components/SubmissionHistory/TotalAggregatesTable.jsx

@@ -109,7 +109,7 @@ export const TotalAggregatesTable = ({ files }) => (
           Status
         </th>
         <th scope="col" rowSpan={2}>
-          Error Reports (In development)
+          Error Reports
         </th>
       </tr>
     </thead>