-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2795 s1 duplicates #2956
2795 s1 duplicates #2956
Conversation
…rating less meaningful messages - Updated error generation
- Add docstrings
…2795-s1-duplicates
…om/raft-tech/TANF-app into 2795-s1-duplicates
- Starting to remove SortedRecordSchemaPairs from case consistency validator - updating to support in memory record removal if they havent been serialized
- Update case consistency validator to not use OG SortedRecordSchemaPairs - Update dup logic to not consider records on the same line
- Add method to generate bulk create dictionary - Stub function for removing cases
- basing off of doc instead of schema
- Updated to use correct error generator
# loop through all t2s and t3s | ||
# to find record where FAMILY_AFFILIATION == 1 | ||
num_errors += self.__validate_family_affiliation(num_errors, t1s, t2s, t3s, ( | ||
f'Every {t1_model_name} record should have at least one corresponding ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicative error messages produced by the following file
Every M1 record should have at least one corresponding M2 or M3 record with the same RPT_MONTH_YEAR and CASE_NUMBER.
Every M1 record should have at least one corresponding M2 or M3 record with the same RPT_MONTH_YEAR and CASE_NUMBER.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elipe17 this is in great shape. couple of suggestions on cat 4 error messages that either need clarity or are redundant and could be dropped.
Testing Summary:
- expected logic is in-place for Section 1 🚀
- expected logic is in-place for Section 2 🚀
- expected logic is in-place for Section 3 🚀
- expected logic is in-place for Section 4 🚀
- cat 4
⚠️ - consistency across tribal, tanf, and ssp 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per our async discussion, i think its worth revisiting the discussion about how many times the cat 4-related error messages appear in the error report, especially in scenarios where these are related to duplicates. this looks great! thanks @elipe17
Summary of Changes
Pull request closes As tech lead, I need TDP to detect duplicate records within a file and not store them in the db. #2795
CPU and Memory Analysis
web
container stats during parsing of the largest file we have in the repo (~50MB) on thedevelop
branch and this branch.super_big_file_results.txt
. The data listed in that text file can be found in the accompanying files:develop_super_big_file.txt
anddup_super_big_file.txt
.track_docker_stats.sh.txt
(GitHub won't let you upload a pure shell file).super_big_file_results.txt
dup_super_big_file.txt
develop_super_big_file.txt
track_docker_stats.sh.txt
How to Test
List the steps to test the PR
These steps are generic, please adjust as necessary.
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure