Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1119 ssp section 3 #2733

Merged
merged 9 commits into from
Nov 21, 2023
Merged

Conversation

jtimpe
Copy link

@jtimpe jtimpe commented Oct 18, 2023

Summary of Changes

Pull request closes #1119

How to Test

cd tdrs-backend && docker-compose up
cd tdrs-frontend && docker-compose up --build
  1. Open http://localhost:3000/ and sign in.
  2. Upload the data file ADS.E2J.NDM3.MS24, selecting SSP-MOE as the program type
  3. Ensure the resulting submission history statuses and error files match the expected output

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

  • Data File parsing logic is in place such that data file submission can be completed by user and parsed by system for full submission once errors are resolved.
  • Data Errors tell user specifically where in the file they occur, and therefore what exactly needs to be fixed in order for the submission to be complete
  • TDP gives the user all data errors for a submission in a way they can easily save or export so they can take the issues back to their case management software and fix the issues then recreate an export for resubmission to TDP.
  • Data Errors must be issued in human readable plain language so that an english speaker can easily understand what is needed.
  • lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?
    • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
    • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Are code maintainability principles being followed?

Deliverable 4: Accessible

  • Does this PR complete the epic?
  • Are links included to any other gov-approved PRs associated with epic?
  • Does PR include documentation for Raft's a11y review?
  • Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

  • Does this PR provide background for why coding decisions were made?
  • If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?
  • Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any new security issues?
  • If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

  • the purpose of the research
  • methods used to conduct the research
  • who participated in the research
  • what was tested and how
  • impact of research on TDP
  • (if applicable) final design mockups produced for TDP development

@jtimpe jtimpe self-assigned this Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2733 (bf8bfba) into develop (b614166) will decrease coverage by 0.36%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2733      +/-   ##
===========================================
- Coverage    92.83%   92.47%   -0.36%     
===========================================
  Files           44      241     +197     
  Lines          977     5412    +4435     
  Branches       160      477     +317     
===========================================
+ Hits           907     5005    +4098     
- Misses          37      314     +277     
- Partials        33       93      +60     
Flag Coverage Δ
dev-backend 92.40% <100.00%> (?)
dev-frontend 92.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...end/tdpservice/parsers/schema_defs/ssp/__init__.py 100.00% <100.00%> (ø)
...s-backend/tdpservice/parsers/schema_defs/ssp/m6.py 100.00% <100.00%> (ø)
tdrs-backend/tdpservice/parsers/util.py 84.73% <ø> (ø)
...ackend/tdpservice/search_indexes/admin/__init__.py 100.00% <100.00%> (ø)
...drs-backend/tdpservice/search_indexes/admin/ssp.py 100.00% <100.00%> (ø)
...backend/tdpservice/search_indexes/documents/ssp.py 100.00% <100.00%> (ø)
...dpservice/search_indexes/migrations/0019_ssp_m6.py 100.00% <100.00%> (ø)
...rs-backend/tdpservice/search_indexes/models/ssp.py 100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ce0a8e...bf8bfba. Read the comment docs.

@jtimpe jtimpe added the raft review This issue is ready for raft review label Oct 19, 2023
Field(item="7C", name='NUM_RECIPIENTS', type='number', startIndex=119, endIndex=127,
required=True, validators=[validators.isInLimits(0, 99999999)]),
Field(item="8C", name='ADULT_RECIPIENTS', type='number', startIndex=143, endIndex=151,
required=True, validators=[validators.isInLimits(0, 99999999)]),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to have a validator or did Alex make a mistake in the spreadsheet?

Copy link

@George-Hudson George-Hudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@raftmsohani raftmsohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ADPennington ADPennington added QASP Review Deploy with CircleCI-qasp Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI labels Nov 20, 2023
Copy link
Collaborator

@ADPennington ADPennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @jtimpe 🚀

  • checked the clean files as well as those with summing issues.
  • also checked that the transformation from qtr to report month was accurate
    ssp_agg_qasp

@ADPennington ADPennington added Ready to Merge and removed QASP Review Deploy with CircleCI-qasp Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI raft review This issue is ready for raft review labels Nov 20, 2023
@andrew-jameson andrew-jameson merged commit 9b1c2d1 into develop Nov 21, 2023
12 checks passed
@andrew-jameson andrew-jameson deleted the feature/1119-ssp-section-3 branch November 21, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants