-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1119 ssp section 3 #2733
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2733 +/- ##
===========================================
- Coverage 92.83% 92.47% -0.36%
===========================================
Files 44 241 +197
Lines 977 5412 +4435
Branches 160 477 +317
===========================================
+ Hits 907 5005 +4098
- Misses 37 314 +277
- Partials 33 93 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 189 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Field(item="7C", name='NUM_RECIPIENTS', type='number', startIndex=119, endIndex=127, | ||
required=True, validators=[validators.isInLimits(0, 99999999)]), | ||
Field(item="8C", name='ADULT_RECIPIENTS', type='number', startIndex=143, endIndex=151, | ||
required=True, validators=[validators.isInLimits(0, 99999999)]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to have a validator or did Alex make a mistake in the spreadsheet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great @jtimpe 🚀
Summary of Changes
Pull request closes #1119
How to Test
ADS.E2J.NDM3.MS24
, selecting SSP-MOE as the program typeDeliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):