Infinite FETCH_STTS

[elipe17]

Summary of Changes

• Updated render/request cycle to manage number of requests sent state to avoid infinitely sending requests.
• Added new error modal to inform user there are issues and that they should log out/log in to see if the issue persists.
  Pull request closes FETCH_STTS Infinite Request #2701

How to Test

• Remove line 99 from docker-compose.yml in the backend folder.

cd tdrs-frontend && docker-compose up
cd tdrs-backend && docker-compose up

1. Log in and get to the Request Access form.
2. You should immediately see the modal displayed in the image below.
3. Sign out and make sure you can sign out
4. Sign back in and verify that you see the error modal again since the stt list still hasnt been populated in the db.
5. exec into the backend container and run python manage.py populate_stts
6. Go back to the Request Access form and verify that you don't get the error modal.

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

• FETCH_STTS should be executed a finite amount of times no matter the response.
• If FETCH_STTS continuously has no response, an error indicating to the user the issue should be thrown.
• Testing Checklist has been run and all tests pass
• README is updated, if necessary

Deliverable 2: Tested Code

• Are all areas of code introduced in this PR meaningfully tested?
  • If this PR introduces backend code changes, are they meaningfully tested?
  • If this PR introduces frontend code changes, are they meaningfully tested?
• Are code coverage minimums met?
  • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
  • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

• Are backend code style checks passing on CircleCI?
• Are frontend code style checks passing on CircleCI?
• Are code maintainability principles being followed?

Deliverable 4: Accessible

• Does this PR complete the epic?
• Are links included to any other gov-approved PRs associated with epic?
• Does PR include documentation for Raft's a11y review?
• Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

• Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

• Does this PR provide background for why coding decisions were made?
• If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
• If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
• If this PR introduces dependencies, are their licenses documented?
• Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

• Does the OWASP Scan pass on CircleCI?
• Do manual code review and manual testing detect any new security issues?
• If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

• the purpose of the research
• methods used to conduct the research
• who participated in the research
• what was tested and how
• impact of research on TDP
• (if applicable) final design mockups produced for TDP development

[codecov]

Codecov Report

Merging #2720 (3aaf5af) into develop (8ec31f9) will decrease coverage by 0.58%.
Report is 55 commits behind head on develop.
The diff coverage is 91.57%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2720      +/-   ##
===========================================
- Coverage    92.99%   92.41%   -0.58%     
===========================================
  Files          219      239      +20     
  Lines         4482     5366     +884     
  Branches       385      476      +91     
===========================================
+ Hits          4168     4959     +791     
- Misses         242      314      +72     
- Partials        72       93      +21     

Flag	Coverage Δ
dev-backend	92.32% <92.15%> (-0.52%)	⬇️
dev-frontend	92.83% <80.64%> (-0.76%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
tdrs-backend/tdpservice/core/logger.py	100.00% <100.00%> (ø)
tdrs-backend/tdpservice/data_files/serializers.py	100.00% <100.00%> (ø)
...rs-backend/tdpservice/data_files/test/factories.py	100.00% <100.00%> (ø)
tdrs-backend/tdpservice/data_files/validators.py	96.15% <ø> (ø)
tdrs-backend/tdpservice/data_files/views.py	90.65% <100.00%> (+0.08%)	⬆️
tdrs-backend/tdpservice/email/email.py	76.78% <100.00%> (-1.55%)	⬇️
...vice/email/helpers/account_deactivation_warning.py	100.00% <100.00%> (ø)
...backend/tdpservice/email/helpers/account_status.py	84.84% <100.00%> (ø)
tdrs-backend/tdpservice/email/helpers/data_file.py	100.00% <100.00%> (ø)
tdrs-backend/tdpservice/parsers/admin.py	100.00% <100.00%> (ø)
... and 54 more

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8f196...3aaf5af. Read the comment docs.

[jtimpe]

good work!

[jtimpe]

minor point but i'd go with something like sttListRequest for the variable name to indicate what's present in the data structure rather than where in the redux stack it comes from

[raftmsohani]

LGTM!

[reitermb]

Looking great on the a11y front. Noting that I documented a related a11y issue (not introduced by this ticket) in #2735.

More documentation to be added following gov a11y sync tomorrow afternoon with @ttran-hub

cc @ADPennington

[ADPennington]

@elipe17 is there a way to test this in a deployed environment? also, can you get this deployed to a dev environment when you get a chance?

[ttran-hub]

Looking great on the a11y front. Noting that I documented a related a11y issue (not introduced by this ticket) in #2735.

More documentation to be added following gov a11y sync tomorrow afternoon with @ttran-hub

cc @ADPennington

a11y LGTM, while potential reading behavior is introduced in #2735.

[ADPennington]

🚀