Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2411 metadata parsed datafiles #2706
2411 metadata parsed datafiles #2706
Changes from 154 commits
210b75c
d70e9c2
2c20472
9c0b25d
fba7f43
b948a5b
c5796da
e6087fd
744ba4d
6bb2017
bd4cc4e
1316a70
e118ff3
21f8954
618d300
953c9ce
b8c5786
70692f3
d9f3a43
3db0af6
83009cb
b11c310
223ff08
297e13d
e9bd47e
c0f5a74
5fca243
a7109c3
21a7006
4597d21
7892115
0c2d57b
35a6f24
0146a0f
d354f71
2807425
6c54528
d1edc20
f75fbca
764e212
45f296d
c0bce69
57c179d
8e7d0e3
bd3558f
2946dad
d9d6be9
5cdb886
fe32cdc
c26703e
075ff86
2ff7d2e
093f67f
9534d25
9a392ba
f8d75cc
a623e00
b6d8b77
0dcd36a
9aef162
91cc331
baffaba
b905667
29fa8b8
ac9b065
6c8b3c4
88d4b62
cb5077c
21b7d66
6d3dfbe
fc02fd7
e137609
9e4e431
af90565
c5196fb
4fc63eb
cc39ddd
a3239c5
29f52e6
89278db
e078f50
2149f07
0fbaf77
f7c6772
46a6d73
f162423
cb01bd3
a194462
c3bfa54
534e635
5e79786
b51a47a
1eb7e9a
15f67ce
a6d528e
ef2793e
9243672
bb158e0
dbac144
755b5bb
2c7efd6
e5108b2
ff1e2b8
496a651
aed64f9
e01ac15
3d444a9
d3bceb7
3cb28b9
94d4b36
90709a3
d55a917
ad8ab50
1648b0c
07b5215
3af7440
b987399
091c8d9
ebeaec8
6fbcebf
6634979
9db047b
8dae7da
0887b89
b9daa9d
a060883
eaab681
d8b7672
af932cd
e4fabbf
181d48d
8564f13
16ebc55
eee7cba
f83c019
49222be
d76d5af
d398ef7
40324b4
02f022a
0f0d4b7
b2a0078
7451813
12d2a58
9363f04
fe08110
24377b2
4ba0395
f74c2bb
a5ccafa
54bdc62
912a9a6
9b1c99a
91c0068
f9a7ac5
c89ebd8
ebf9956
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really specific to this PR, but similar logic is repeated everywhere and i keep thinking we should have a first-class member for the program type. similar to my other comment this would also allow you to use a native django list filter for the program type without creating a custom class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having prog_type as property means calculation is done in backend server vs DB. While normally querying the DB is faster, there are cases where pushing the query into DB is not efficient since during writing to prog_type need a db_lock. An example is calculated values where property can change base on two, three different fields.
Having said that, in this case since prog_type only needs to be updated during the initial write, I agree with your suggestion