forked from HHS/TANF-app
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/1111 tanf section 4 #2657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added t2.py - Updating var names to match field names
…2424-ts1-parsing
- Updated model fo rT2 - Added active parse function
- updated field names
…feature/1113-1-ssp-section-1-models
- Updated test file
…2424-ts1-parsing
This reverts commit 1455ae4.
…com/raft-tech/TANF-app into feature/1113-1-ssp-section-1-models
….com/raft-tech/TANF-app into 2424-ts1-parsing
- Combined migrations
jtimpe
added
Deploy with CircleCI-sandbox
and removed
Deploy with CircleCI-sandbox
labels
Sep 27, 2023
@ADPennington 1111 is now deployed to sandbox |
ADPennington
added
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
and removed
Deploy with CircleCI-sandbox
labels
Sep 27, 2023
Co-authored-by: Alex P. <[email protected]>
ADPennington
added
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
and removed
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
labels
Sep 28, 2023
ADPennington
added
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
QASP Review
and removed
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
labels
Sep 29, 2023
ADPennington
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent work @jtimpe 🚀
ADPennington
added
Ready to Merge
and removed
raft review
This issue is ready for raft review
QASP Review
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
labels
Sep 29, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Pull request closes #1111
Adds parsing/validation for TANF section 4 submissions (T7 data row)
How to Test
List the steps to test the PR
These steps are generic, please adjust as necessary.
ADS.E2J.FTP4.TS06
included in the test data folder to TANF Section 4T7
andParserError
records are created as expectedDeliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):