make array type printing consistent with base #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`print_type` was missing a space inside the curly brackets. (My IDE automatically removed trailing whitespace here, lmk if I should remove those changes.)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #854 +/- ##
==========================================
+ Coverage 83.38% 84.41% +1.02%
==========================================
Files 46 50 +4
Lines 4634 4677 +43
==========================================
+ Hits 3864 3948 +84
+ Misses 770 729 -41 ☔ View full report in Codecov by Sentry. |
|
I think base added that space a few years ago? I kind of don't like spaces in types but yeah, let's standardise. You will need to run the doctests with |
Yes, it was changed in JuliaLang/julia#37085 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
print_typewas missing a space inside the curly brackets. (My IDEautomatically removed trailing whitespace here, lmk if I should remove
those changes.)