-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Interpolations.jl extension #586
base: main
Are you sure you want to change the base?
Conversation
ff89cd9
to
06b5cd7
Compare
Closes #420 @DanDeepPhase we can implement this pretty easily now. But if you have any comments on syntax or how this should work that would help. See the new tests added here for an example. |
Any particular reason this was closed? |
In favour of Which needs tests, and I forgot about. And I'm not really sure on the best syntax. Feedback appreciated. |
* linear interpolation * Apply suggestions from code review Co-authored-by: Rafael Schouten <[email protected]> * Simpler implementation * compat * fixed typo missed = * Update ext/DimensionalDataInterpolations.jl * Update ext/DimensionalDataInterpolations.jl --------- Co-authored-by: Rafael Schouten <[email protected]>
Did #609 get merged here? I don't see the log |
It got merged to the branch yes, but the PR seems dead there's no reopen button Maybe that's just a phone app thing idk |
I guess the PR had to be reopened for the log to refresh... |
It's just a little tricky getting the syntax right, if you want to take over find shing the PR that would help it along |
This is an idea for adding an Interpolations.jl extension.
It turns out there isn't a clean way to extend Interpolations.jl methods like
interpolate
orscale
because really on aDimArray
you would always want both and have the information for both already in one object.So the idea here (and what i personally need the most) is to define an interpolation method that lets you interpolate from one
AbstractDimArray
to another in a single command.We have most of the information we need to choose the interpolation method - users can specify e.g.
Cubic
orLinear
if they really want to. ButBSpline
/Gridded
we know fromRegular
/Irregular
etc.We may also want to provide an interpolator object that can interpolate points.
I'll probably leave this here for a while until its clearer what the best strategy is, but comments are welcome.