Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Stack rand #567

Merged
merged 5 commits into from
Feb 4, 2024
Merged

Breaking: Stack rand #567

merged 5 commits into from
Feb 4, 2024

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Nov 20, 2023

add a rand method for DimStack

This is a breaking change because it required fixes to eltype (which previously made no sense - a constructed NamedTuple of types rather than a Type{NamedTuple})

This PR also fixes a bug in linear indexing with mixed size layers.

@rafaqz rafaqz marked this pull request as ready for review November 20, 2023 14:08
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d927b77) 87.23% compared to head (6e45fef) 87.17%.

Files Patch % Lines
src/stack/indexing.jl 85.71% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   87.23%   87.17%   -0.06%     
==========================================
  Files          43       43              
  Lines        3446     3471      +25     
==========================================
+ Hits         3006     3026      +20     
- Misses        440      445       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaqz rafaqz changed the title Stack rand Breaking: Stack rand Jan 14, 2024
@rafaqz rafaqz merged commit a9dd0e9 into main Feb 4, 2024
9 of 11 checks passed
@rafaqz rafaqz deleted the stack_rand branch February 4, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants