Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ambiguity tests now they dont fail erroneously #541

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Sep 26, 2023

Tested with JET rather than writing tests for every added disambiguation.

@rafaqz rafaqz marked this pull request as ready for review September 26, 2023 20:55
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #541 (7baea2c) into main (cd77569) will increase coverage by 0.22%.
Report is 2 commits behind head on main.
The diff coverage is 31.74%.

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   83.13%   83.35%   +0.22%     
==========================================
  Files          40       40              
  Lines        3297     3527     +230     
==========================================
+ Hits         2741     2940     +199     
- Misses        556      587      +31     
Files Coverage Δ
src/Dimensions/Dimensions.jl 100.00% <ø> (ø)
src/array/indexing.jl 86.84% <100.00%> (+0.35%) ⬆️
src/array/matmul.jl 90.32% <ø> (ø)
src/dimindices.jl 97.26% <100.00%> (+0.03%) ⬆️
src/Dimensions/format.jl 88.00% <0.00%> (-1.19%) ⬇️
src/LookupArrays/selector.jl 90.41% <66.66%> (+2.76%) ⬆️
src/LookupArrays/set.jl 91.17% <0.00%> (-1.37%) ⬇️
src/utils.jl 96.82% <66.66%> (ø)
src/array/methods.jl 86.89% <57.14%> (-0.61%) ⬇️
src/Dimensions/primitives.jl 86.11% <33.33%> (-0.61%) ⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rafaqz rafaqz merged commit 4f7f056 into main Sep 26, 2023
9 checks passed
@rafaqz rafaqz deleted the ambiguities branch September 26, 2023 22:40
@sethaxen sethaxen mentioned this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants