Skip to content

Commit

Permalink
tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
rafaqz committed Sep 4, 2023
1 parent 0d137f4 commit e111d44
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ext/DimensionalDataMakie.jl
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ for (f1, f2) in _paired(:plot => :heatmap, :heatmap, :image, :contour, :contourf
end
return p
end
function Makie.$f1!(A::AbstractDimArray{<:Any,2}; dims=(), attributes...)
function Makie.$f1!(axis, A::AbstractDimArray{<:Any,2}; dims=(), colorbarkw=(;), attributes...)
args, _ = _surface2(A, attributes, dims)
# No ColourBar in the ! in-place versions
return Makie.$f2!(args...; attributes...)
Expand Down Expand Up @@ -236,11 +236,11 @@ function _series(A, attributes, labeldim)
isnothing(categoricaldim) && throw(ArgumentError("No dimensions have Categorical lookups"))
categoricallookup = parent(categoricaldim)
otherdim = only(otherdims(A, categoricaldim))
lookup_attributes, otherdim1 = _split_attributes(X(lookup(otherdim)))
args = vec(lookup(otherdim1)), parent(permutedims(A, (categoricaldim, otherdim)))

# Plot attribute generation
user_attributes = Makie.Attributes(; attributes...)
lookup_attributes, otherdim1 = _split_attributes(X(lookup(otherdim)))
plot_attributes = Makie.Attributes(;
labels=string.(parent(categoricallookup)),
axis=(;
Expand Down

0 comments on commit e111d44

Please sign in to comment.