better reorder

.github/workflows/Documenter.yml

@@ -22,7 +22,7 @@ jobs:
         with:
           cache-registries: "true"
       - name: Install documentation dependencies
-        run: julia --project=docs -e 'using Pkg; pkg"dev ."; Pkg.instantiate()'
+        run: julia --project=docs -e 'using Pkg; pkg"dev ."; pkg"dev BaseInterfaces"; Pkg.instantiate()'
       - name: Build and deploy
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # For authentication with GitHub Actions token
@@ -32,4 +32,4 @@ jobs:
           DATADEPS_ALWAYS_ACCEPT: true
         run: |
           julia --code-coverage=user --project=docs/ --color=yes docs/genfiles.jl
-          julia --code-coverage=user --project=docs/ --color=yes docs/make.jl
+          julia --code-coverage=user --project=docs/ --color=yes docs/make.jl

src/utils.jl

@@ -26,7 +26,8 @@ reorder(dim::Dimension, ot::Type{<:Order}) =
 _reorder(x, orderdims::DimTuple) = _reorder(reorder(x, orderdims[1]), tail(orderdims))
 _reorder(x, orderdims::Tuple{}) = x
 
-reorder(x, orderdim::Dimension) = _reorder(val(orderdim), x, dims(x, orderdim))
+reorder(x, orderdim::Dimension{<:Order}) = _reorder(val(orderdim), x, dims(x, orderdim))
+reorder(x, orderdim::Dimension{<:LookupArray}) = _reorder(order(orderdim), x, dims(x, orderdim))
 
 _reorder(neworder::Order, x, dim::Dimension) = _reorder(basetypeof(neworder), x, dim)
 # Reverse the dimension index

test/utils.jl

@@ -75,6 +75,13 @@ end
     d = reorder(dims(da, Y), ForwardOrdered()) 
     @test order(d) isa ForwardOrdered
     @test index(d) == 100:100:300
+
+    # reorder with dimension lookups
+    rev = reverse(da, dims=Y)
+    reo = reorder(rev, dims(da))
+    @test rev != da
+    @test reo == da
+    @test dims(reo) == dims(da)
 end
 
 @testset "modify" begin