Improve handling for players leaving/joining multiplayer games during votes #298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts voting in the following ways:
Previously, the behaviour for players who join/leave during a vote was relatively unintuitive - ie. players who joined during a vote were excluded from participating (despite receiving a reminder to do so), and a vote was still being expected from players who had already left the game.
This new approach is much more intuitive and is, I think, in line with how many players already thought the feature was working.