Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling for players leaving/joining multiplayer games during votes #298

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

GooberRF
Copy link
Contributor

This PR adjusts voting in the following ways:

  • When all players have left the server, an active vote is now automatically canceled.
  • When the person who called a vote leaves the server, the vote is now automatically canceled.
  • Newly joined players can now participate in the vote.
  • Players who leave during a vote are now automatically removed from influence on the vote outcome - if they didn't vote, they're no longer considered; if they did vote, that vote is removed/ignored.

Previously, the behaviour for players who join/leave during a vote was relatively unintuitive - ie. players who joined during a vote were excluded from participating (despite receiving a reminder to do so), and a vote was still being expected from players who had already left the game.

This new approach is much more intuitive and is, I think, in line with how many players already thought the feature was working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant