fix panic when file/dir is deleted #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes when a file/dir which is being watched is deleted a panic will occur. This appears to be because the is an assumption that if an error returns true for `IsNotExist()` that it should be castable to `os.PathError`, but this evidently is not always the case, causing a panic.
|
Hi @radovskyb any plans to review and merge this anytime soon? I'm hitting the same issue as @tul |
dideler
added a commit
to dideler/watcher
that referenced
this pull request
Apr 21, 2020
Applied patch from radovskyb#96
|
@radovskyb +1 to merge this change as is. It's really annoying for directories with dense create and delete operations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when a file/dir which is being watched is deleted a panic will occur. This appears to be because there is an assumption that if an error returns true for
IsNotExist()that it should be castable toos.PathError, but this evidently is not always the case, causing a panic.