Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bicep download from GHCR #592

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Update bicep download from GHCR #592

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53f118b
add GH login
sk593 Oct 11, 2023
362ebcc
nit
sk593 Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ on:
env:
RAD_CLI_URL: https://get.radapp.dev/tools/rad/install.sh
RUN_IDENTIFIER: samplestest-${{ github.run_id }}-${{ github.run_attempt }}
GHCR_ACTOR: rad-ci-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is temporary could you move this down to be a direct value instead of an environment variable? And could you add a comment saying to remove this once we go public?

jobs:
test:
name: Sample tests
Expand Down Expand Up @@ -179,6 +180,12 @@ jobs:
run: |
helm repo add dapr https://dapr.github.io/helm-charts/
helm install dapr dapr/dapr --version=1.6 --namespace dapr-system --create-namespace --wait
- name: Login to GitHub Container Registry
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ env.GHCR_ACTOR }}
password: ${{ secrets.GH_RAD_CI_BOT_PAT }}
- name: Download rad CLI
if: steps.gen-id.outputs.RUN_TEST == 'true'
run: |
Expand Down
Loading