Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eshop on recipes reference application #553

Closed
wants to merge 2 commits into from

Conversation

willdavsmith
Copy link
Contributor

@willdavsmith willdavsmith commented Sep 13, 2023

Continuation of #410

  • Adding eshop on recipes as a new reference application

@willdavsmith willdavsmith changed the title Add eshop on recipes Add eshop on recipes reference application Sep 14, 2023
@willdavsmith willdavsmith marked this pull request as ready for review September 21, 2023 18:02
@willdavsmith willdavsmith requested a review from a team as a code owner September 21, 2023 18:02
@@ -5,5 +5,6 @@ Reference apps are templates that show a complete app. You are able to clone and
| Reference app | Description |
|---------------|-------------|
| [eShop](./eshop) | A full retail microservices application. |
| [eShop on Recipes](./eshop-recipes) | A full retail microservices application leveraging Radius recipes for infrastructure deployment and management |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of making this a separate app let's just go ahead and have one version of eshop that's Recipes. No need to retain the old one.

name: 'servicebus'
parameters: {
topicName: 'eshop_event_bus'
subscriptions: ['Basket', 'Catalog', 'Ordering', 'GracePeriod', 'Payment', 'backgroundtasks', 'Ordering.signalrhub', 'Webhooks']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is suuuuuper cool 🔥

}


// ROUTES ----------------------------------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sync with @nithyatsu about switching away from routes to the new dns-sd feature

@lakshmimsft
Copy link
Contributor

lakshmimsft commented Oct 5, 2023

  1. Pls update api version to "2023-10-01-preview" for all resources per recent update.
  2. Question: For my info, where are the recipes located at radiusdev.azurecr.io/recipes/aws/sqldatabases, radius.azurecr.io/recipes/aws/rediscaches located and the call to publish them?

@willdavsmith
Copy link
Contributor Author

closing in favor of #590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants