Add eshop UI tests on AWS #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdavsmith
changed the title
willdavsmith
commented
Sep 11, 2023
willdavsmith
commented
Sep 11, 2023
willdavsmith
commented
Sep 11, 2023
willdavsmith
commented
Sep 12, 2023
| "@playwright/test": "^1.35.0", | ||
| "@types/node": "^20.6.0", | ||
| "@types/uuid": "^9.0.3", | ||
| "typescript": "^5.2.2" |
There was a problem hiding this comment.
Adding dev dependencies because I was getting typescript compile errors
willdavsmith
commented
Sep 12, 2023
| expect(endpoint).toBeDefined() | ||
|
|
||
| // Remove quotes from the endpoint if they exist | ||
| endpoint = (endpoint as string).replace(/['"]+/g, '') |
There was a problem hiding this comment.
fixing compile errors
willdavsmith
commented
Sep 12, 2023
| @@ -0,0 +1,109 @@ | |||
| { | |||
There was a problem hiding this comment.
I generated this from tsc --init
kachawla
reviewed
Sep 15, 2023
There was a problem hiding this comment.
@willdavsmith can you please fork out and merge workflow fixes to edge/0.25? These fixes are required to run samples workflows, so not blocking them on rest of the changes in this pr will help.
AaronCrawfis
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #378
Example successful run: https://github.com/radius-project/samples/actions/runs/6162147507/job/16722985776?pr=552
https://github.com/radius-project/samples/actions/runs/6163158641/job/16726122506?pr=552