Update devcontainer for v0.12 #23
Conversation
| RUN apt-get update && /bin/bash /tmp/library-scripts/docker-in-docker-debian.sh | ||
| ENTRYPOINT ["/usr/local/share/docker-init.sh"] | ||
| VOLUME [ "/var/lib/docker" ] | ||
| CMD ["sleep", "infinity"] |
There was a problem hiding this comment.
This ins't needed. The use of features for docker-in-docker supersedes this.
| RUN wget -O /home/rad-vscode-bicep.vsix https://get.radapp.dev/tools/vscode/stable/rad-vscode-bicep.vsix | ||
| RUN wget -O /home/rad-vscode.vsix https://get.radapp.dev/tools/vscode/stable/rad-vscode.vsix | ||
| RUN wget -O /home/rad-vscode-bicep.vsix https://radiuspublic.blob.core.windows.net/tools/vscode-extensibility/edge/rad-vscode-bicep.vsix | ||
| RUN wget -O /home/rad-vscode.vsix https://radiuspublic.blob.core.windows.net/tools/vscode/edge/rad-vscode.vsix |
There was a problem hiding this comment.
We don't have versioned links for these yet. We should do this when we're ready to cut a build.
tutorial/template.bicep
Outdated
| environment: app.properties.environment | ||
| application: app.id | ||
| secrets: { | ||
| connectionString: '' // Put your connection string here! |
There was a problem hiding this comment.
The starter does work so I ripped it out. I'm planning a follow-up here to use k8s extensiblity.
| name: 'webapp' | ||
| location: 'global' |
There was a problem hiding this comment.
Locations will all need to be updated to resourceGroup().location to pass validation
There was a problem hiding this comment.
Then we should turn off that validation. That's a really misleading thing for us to put in our code.
I'll follow up on the changes to the bicep file separately. |
|
@AaronCrawfis - it looks like the bicep validation is failing due to using the old compiler. Is this something that's already being updated or did I do something wrong? |
|
@Reshrahim @AaronCrawfis - do either of you know of plans to migrate the bicep file that's failing in this PR's validation? or have ideas on whether we need a different version in the repo? |
|
|
|
This thread seems to be the culprit: k3s-io/k3s#4638 |
|
@AaronCrawfis @jasonviviano - I've also updated the Bicep for the sample, and mongo works now! This has a dependency on this change: radius-project/radius#3165 |
rynowak
force-pushed
the
rynowak/v0.12-codespaces
branch
from
430d208 to
5ad4167
Compare
rynowak
force-pushed
the
rynowak/v0.12-codespaces
branch
from
5ad4167 to
f4775b4
Compare
|
Bicep validation was failing because these scripts were not marked as executable:
|
For now I've manually built and pushed the base image.