Change references in samples tests to correct versions #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
willdavsmith
commented
Sep 11, 2024
willdavsmith
commented
- Update release process to include bicepconfig.json
- Fix tests to use versions instead of latest for everything
Signed-off-by: willdavsmith <[email protected]>
willdavsmith
commented
Sep 11, 2024
| @@ -4,17 +4,9 @@ on: | |||
| workflow_dispatch: | |||
| inputs: | |||
| version: | |||
| description: "Radius version number to use (e.g. 0.1.0, 0.1.0-rc1, edge). Defaults to edge." | |||
There was a problem hiding this comment.
I removed this default to disambiguate how "defaults" work
willdavsmith
commented
Sep 11, 2024
| type: string | ||
| push: |
There was a problem hiding this comment.
I don't think we need to run on push
There was a problem hiding this comment.
I still think we should test on pushes. even if the PR runs pass, we've sometimes seen failures on pushes in other repos and runs
There was a problem hiding this comment.
ok, I re-added this trigger
willdavsmith
commented
Sep 11, 2024
| @@ -93,7 +85,6 @@ jobs: | |||
| credential: aws | |||
| enableDapr: false | |||
| env: | |||
| BRANCH: ${{ github.base_ref || github.ref_name }} | |||
There was a problem hiding this comment.
this was unused
sk593
reviewed
Sep 11, 2024
willdavsmith
commented
Sep 11, 2024
Signed-off-by: willdavsmith <[email protected]>
willdavsmith
commented
Sep 11, 2024
|
|
||
| # Update bicepconfig.json br:biceptypes.azurecr.io/radius with the CHANNEL | ||
| BICEPCONFIG_RADIUS_STRING_REPLACEMENT="br:biceptypes.azurecr.io/radius:${CHANNEL}" | ||
| awk -v REPLACEMENT="${BICEPCONFIG_RADIUS_STRING_REPLACEMENT}" '{gsub(/br:biceptypes\.azurecr\.io\/radius:latest/, REPLACEMENT); print}' bicepconfig.json > bicepconfig_updated.json |
There was a problem hiding this comment.
this is what we do for docs as well: https://github.com/radius-project/docs/blob/943c2cf3ea6b0d5cc24b06f6fa9de54e14207355/.github/scripts/release-docs.sh#L48
Signed-off-by: willdavsmith <[email protected]>
sk593
approved these changes
Sep 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.