updating samples for new environment variables schema #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Beenham <[email protected]>
kachawla
approved these changes
Aug 30, 2024
Comment on lines
+42
to
+50
| AWS_ACCESS_KEY_ID: { | ||
| value: aws_access_key_id | ||
| } | ||
| AWS_SECRET_ACCESS_KEY: { | ||
| value: aws_secret_access_key | ||
| } | ||
| AWS_DEFAULT_REGION: { | ||
| value: aws_region | ||
| } |
There was a problem hiding this comment.
This is a good use case for the secrets support you have added @superbeeny
kachawla
added a commit
to kachawla/samples
that referenced
this pull request
Sep 6, 2024
Related to: radius-project#1742 Signed-off-by: karishma-chawla <[email protected]>
kachawla
added a commit
that referenced
this pull request
Sep 6, 2024
* Dapr Resource Schema Update More context: radius-project/radius#7823 Signed-off-by: karishma-chawla <[email protected]> * Update env vars schema Related to: #1742 Signed-off-by: karishma-chawla <[email protected]> --------- Signed-off-by: karishma-chawla <[email protected]> Co-authored-by: karishma-chawla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated url readme as well