Fixing the eShop catalog load issue for the UI tests #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytimocin
force-pushed
the
ytimocin/catalogLoadError
branch
5 times, most recently
from
3ba6223 to
dc59967
Compare
kachawla
reviewed
May 7, 2024
@kachawla do you mean the test run or do you get an error when you deploy the application? |
I meant test run for this PR :) |
Ah, yes! This is actually the error I am trying to fix, and it has an issue so that it can be tracked: #1545. |
ytimocin
force-pushed
the
ytimocin/catalogLoadError
branch
from
dc59967 to
bb62ecd
Compare
I meant the approval workflow for this PR was failing, looks like it's not anymore. The changes look good to me |
kachawla
approved these changes
May 9, 2024
ytimocin
force-pushed
the
ytimocin/catalogLoadError
branch
from
bb62ecd to
0689755
Compare
ytimocin
force-pushed
the
ytimocin/catalogLoadError
branch
from
0689755 to
f92dc65
Compare
rynowak
reviewed
May 14, 2024
rynowak
reviewed
May 14, 2024
|
|
||
| while (attempts < maxAttempts) { | ||
| try { |
There was a problem hiding this comment.
Can you explain why the try/catch isn't needed anymore?
rynowak
reviewed
May 14, 2024
Signed-off-by: ytimocin <[email protected]>
ytimocin
force-pushed
the
ytimocin/catalogLoadError
branch
from
f92dc65 to
57ecfb8
Compare
rynowak
approved these changes
May 14, 2024
sk593
pushed a commit
that referenced
this pull request
May 23, 2024
Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]>
sk593
pushed a commit
that referenced
this pull request
May 23, 2024
Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]>
sk593
added a commit
that referenced
this pull request
May 23, 2024
* update gh to ado sync workflow to use service principals (#1363) * Make env configurable (#1046) Signed-off-by: Reshma Abdul Rahim <[email protected]> * Adding test AKS workflow to v0.32 (#1052) * Run functional tests every 2 hours and add another workflow that runs… (#1020) * Run functional tests every 2 hours and add another workflow that runs the tests on AKS instead of k3d Signed-off-by: ytimocin <[email protected]> * Triggering workflow Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Removing the run of the AKS workflow on PRs (#1051) Signed-off-by: ytimocin <[email protected]> * Update the timeout (30s) for Playwright Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Use retry and update eshop playwright tests to wait for the catalog to appear (#1213) Signed-off-by: ytimocin <[email protected]> * update gh to ado sync workflow to use service principals Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: ytimocin <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Yetkin Timocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Workflow and playwright test updates (#1360) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Changing the place of page.reload in the tests (#1492) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Adding a job that will purge AWS EKS clusters every 6 hours (#1462) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Update all deps of all apps (#1536) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Updating the runner of purge azure test resources workflow (#1537) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Update purget test resources to fix the workflow failures (#1552) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Fixing the eShop catalog load issue for the UI tests (#1548) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: ytimocin <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: sk593 <[email protected]> Co-authored-by: Will <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Yetkin Timocin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catalog is not loading in some cases in eShop on Containers.
This PR aims to fix this issue by adding page reloading mechanism: #1545.