Skip to content

Commit

Permalink
review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nithyatsu committed Oct 30, 2023
1 parent de7bc5f commit d68a31e
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,8 @@ jobs:
- directory: samples/volumes/
image: samples/volumes
steps:
- name: Evaluate push
id: eval_push
run: |
if [[ "${{ github.event_name }}" == "push" ]]; then
PUSH_IMAGE='true'
else
PUSH_IMAGE='false'
fi
echo "PUSH_IMAGE=${PUSH_IMAGE}" >> $GITHUB_OUTPUT
- name: Checkout code
uses: actions/checkout@v4
# Using fromJSON to convert string to boolean. Ref. https://github.com/actions/runner/issues/1483
- name: Login to GitHub Container Registry
uses: docker/login-action@v2
with:
Expand All @@ -69,5 +59,4 @@ jobs:
with:
context: ./${{ matrix.directory }}
push: ${{ github.event_name == 'push' && true || false }}
# push: ${{ fromJSON(steps.eval_push.outputs.PUSH_IMAGE) }}
tags: ${{ env.CONTAINER_REGISTRY }}/${{ matrix.image }}:${{ env.VERSION }}

0 comments on commit d68a31e

Please sign in to comment.