I think it works

radius-project · Sep 12, 2023 · 17e94a7 · 17e94a7
1 parent dbab081
commit 17e94a7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -63,19 +63,19 @@ jobs:
             runOnPullRequest: true
             app: eshop
             path: ./reference-apps/eshop/iac/eshop.bicep
-            args: -p appName eshop
+            args: -p appName=eshop
             uiTestFile: tests/eshop/container.app.spec.ts
             enableDapr: false
           - name: eshop-azure
-            runOnPullRequest: true #false
+            runOnPullRequest: false
             app: eshop-azure
             path: ./reference-apps/eshop/iac/eshop.bicep
             args: -p platform=azure -p appName=eshop-azure
             uiTestFile: tests/eshop/container.app.spec.ts
             credential: azure
             enableDapr: false
           - name: eshop-aws
-            runOnPullRequest: true #false
+            runOnPullRequest: false
             app: eshop-aws-${{ github.run_id }}-${{ github.run_attempt }}
             path: ./reference-apps/eshop/iac/eshop.bicep
             args: -p platform=aws -p eksClusterName=eks-samplestest-${{ github.run_id }}-${{ github.run_attempt }}-eshop-aws -p appName=eshop-aws-${{ github.run_id }}-${{ github.run_attempt }}
@@ -249,9 +249,11 @@ jobs:
           cd ui-tests/
           npm ci
           npx playwright install --with-deps
-          endpoint=$(rad app status -o json -a ${{ matrix.app }} | sed 's/ /\n/g' | grep http)
-          echo $endpoint
-          export ENDPOINT=$endpoint
+          if [[ "${{ matrix.container }}" != "" ]]; then
+            endpoint=$(rad app status -o json -a ${{ matrix.app }} | sed 's/ /\n/g' | grep http)
+            echo $endpoint
+            export ENDPOINT=$endpoint
+          fi
           npx playwright test ${{ matrix.uiTestFile }} --retries 3
       - name: Upload Playwright Results
         uses: actions/upload-artifact@v3

diff --git a/ui-tests/deleted-resources.txt b/ui-tests/deleted-resources.txt