Implement resource provider API for dynamic rp #8177

rynowak · 2024-12-30T22:33:33Z

Description

This change implements the standard resource provider API for dynamic resources. This enables the dynamic-rp to serve the standard CRUDL API functionality for user-defined types.

This change does NOT add recipe support, that will come in the next change. The pattern that's supported by this change is an "inert" resource which has no backend functionality. Recipe support will be a superset of this functionality.

Type of change

Part of: #6688

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

This change implements the standard resource provider API for dynamic resources. This enables the dynamic-rp to serve the standard CRUDL API functionality for user-defined types. This change does NOT add recipe support, that will come in the next change. The pattern that's supported by this change is an "inert" resource which has no backend functionality. Recipe support will be a superset of this functionality. Signed-off-by: Ryan Nowak <[email protected]>

rynowak · 2024-12-30T22:47:26Z

.github/workflows/lint.yaml

@@ -104,6 +104,7 @@ jobs:
          node-version: "22"
      - name: Run `make format-check`
        id: format-check
+        continue-on-error: true


@ytimocin - there were some bugs in this check. See failed run here: https://github.com/radius-project/radius/actions/runs/12552709770/job/34999066289?pr=8177

rynowak · 2024-12-30T22:47:45Z

build/prettier.mk

@@ -14,16 +14,18 @@
 # limitations under the License.
 # ------------------------------------------------------------

-.PHONY: prettier-check prettier-format me prettier
+##@ Formatting (of JSON files)


@ytimocin - this was missing from the help displayed when running make.

rynowak · 2024-12-30T22:48:13Z

build/prettier.mk

 	@echo "$(ARROW) Reformatting files using prettier..."
 	@echo ""
-	@npx prettier@$(PRETTIER_VERSION) --write "*/**/*.{ts,js,mjs,json}"
+	@npx --yes prettier@$(PRETTIER_VERSION) --write "*/**/*.{ts,js,mjs,json}"


@ytimocin --yes should be included here to suppress the prompt.

codecov · 2024-12-30T23:01:51Z

Codecov Report

Attention: Patch coverage is 69.27374% with 55 lines in your changes missing coverage. Please review.

Project coverage is 60.05%. Comparing base (4952890) to head (d9a16ec).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/dynamicrp/api/dynamicresource_conversion.go	69.56%	14 Missing and 7 partials ⚠️
...kg/dynamicrp/backend/dynamicresource_controller.go	55.88%	13 Missing and 2 partials ⚠️
...p/datamodel/converter/dynamicresource_converter.go	59.09%	6 Missing and 3 partials ⚠️
pkg/dynamicrp/backend/service.go	0.00%	7 Missing ⚠️
pkg/dynamicrp/backend/inert_delete_controller.go	70.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8177      +/-   ##
==========================================
- Coverage   60.07%   60.05%   -0.03%     
==========================================
  Files         579      584       +5     
  Lines       38504    38675     +171     
==========================================
+ Hits        23133    23226      +93     
- Misses      13669    13737      +68     
- Partials     1702     1712      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2024-12-31T17:57:25Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`abe5efc`
Unique ID	func35a0727056
Image tag	pr-func35a0727056

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func35a0727056
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func35a0727056
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func35a0727056
controller test image location: ghcr.io/radius-project/dev/controller:pr-func35a0727056
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func35a0727056
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2024-12-31T22:34:12Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	rynowak/radius
Commit ref	`d9a16ec`
Unique ID	func9e436a0425
Image tag	pr-func9e436a0425

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func9e436a0425
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func9e436a0425
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func9e436a0425
controller test image location: ghcr.io/radius-project/dev/controller:pr-func9e436a0425
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func9e436a0425
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded

rynowak · 2024-12-31T22:53:14Z

Merging this to unblock the next steps. Will address any feedback in a follow-up.

rynowak requested review from a team as code owners December 30, 2024 22:33

rynowak temporarily deployed to publish-bicep December 30, 2024 22:33 — with GitHub Actions Inactive

rynowak force-pushed the dynamic-rp-api branch from cf2ac64 to 4986d34 Compare December 30, 2024 22:35

rynowak temporarily deployed to publish-bicep December 30, 2024 22:35 — with GitHub Actions Inactive

rynowak force-pushed the dynamic-rp-api branch from 4986d34 to abe5efc Compare December 30, 2024 22:47

rynowak commented Dec 30, 2024

View reviewed changes

rynowak temporarily deployed to publish-bicep December 30, 2024 22:47 — with GitHub Actions Inactive

rynowak commented Dec 30, 2024

View reviewed changes

rynowak temporarily deployed to functional-tests December 31, 2024 17:56 — with GitHub Actions Inactive

Merge branch 'main' into dynamic-rp-api

d9a16ec

rynowak temporarily deployed to publish-bicep December 31, 2024 22:31 — with GitHub Actions Inactive

rynowak temporarily deployed to functional-tests December 31, 2024 22:33 — with GitHub Actions Inactive

rynowak merged commit 710509a into radius-project:main Dec 31, 2024
29 checks passed

rynowak deleted the dynamic-rp-api branch December 31, 2024 22:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement resource provider API for dynamic rp #8177

Implement resource provider API for dynamic rp #8177

rynowak commented Dec 30, 2024

rynowak Dec 30, 2024

rynowak Dec 30, 2024

rynowak Dec 30, 2024 •

edited

Loading

codecov bot commented Dec 30, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 31, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 31, 2024 •

edited

Loading

rynowak commented Dec 31, 2024

Implement resource provider API for dynamic rp #8177

Implement resource provider API for dynamic rp #8177

Conversation

rynowak commented Dec 30, 2024

Description

Type of change

Contributor checklist

rynowak Dec 30, 2024

Choose a reason for hiding this comment

rynowak Dec 30, 2024

Choose a reason for hiding this comment

rynowak Dec 30, 2024 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Dec 30, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Dec 31, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Dec 31, 2024 • edited Loading

Radius functional test overview

Test Status

rynowak commented Dec 31, 2024

rynowak Dec 30, 2024 •

edited

Loading

codecov bot commented Dec 30, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 31, 2024 •

edited

Loading

radius-functional-tests bot commented Dec 31, 2024 •

edited

Loading