-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move shared services and host to components #8160
Conversation
This change moves the shared host package and diagnostics services to the new `pkg/components` folder. Also simplifies and improves consistency. As part of this work, I made changes to the configuration file for consistency. Each of these diagnostics features now has a dedicated on/off switch. Where a service name is required, it is now specific in configuration rather than hardcoded in the code. Also made the names of configuration files consistent and reflective of their scenario. All of the configuration files used for development reflect the 'dev' terminology. All of the configuration files used for self-hosted Radius (in Kubernetes) reflect the 'self-hosted' terminology. Signed-off-by: Ryan Nowak <[email protected]>
2545e00
to
f59e2e3
Compare
docs/contributing/contributing-code/contributing-code-control-plane/configSettings.md
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8160 +/- ##
==========================================
+ Coverage 60.03% 60.08% +0.05%
==========================================
Files 581 579 -2
Lines 38536 38504 -32
==========================================
+ Hits 23135 23136 +1
+ Misses 13700 13668 -32
+ Partials 1701 1700 -1 ☔ View full report in Codecov by Sentry. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
This change moves the shared host package and diagnostics services to the new
pkg/components
folder. Also simplifies and improves consistency.As part of this work, I made changes to the configuration file for consistency. Each of these diagnostics features now has a dedicated on/off switch. Where a service name is required, it is now specific in configuration rather than hardcoded in the code.
Also made the names of configuration files consistent and reflective of their scenario. All of the configuration files used for development reflect the 'dev' terminology. All of the configuration files used for self-hosted Radius (in Kubernetes) reflect the 'self-hosted' terminology.
Type of change
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: