Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shared services and host to components #8160

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

rynowak
Copy link
Contributor

@rynowak rynowak commented Dec 20, 2024

Description

This change moves the shared host package and diagnostics services to the new pkg/components folder. Also simplifies and improves consistency.

As part of this work, I made changes to the configuration file for consistency. Each of these diagnostics features now has a dedicated on/off switch. Where a service name is required, it is now specific in configuration rather than hardcoded in the code.

Also made the names of configuration files consistent and reflective of their scenario. All of the configuration files used for development reflect the 'dev' terminology. All of the configuration files used for self-hosted Radius (in Kubernetes) reflect the 'self-hosted' terminology.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@rynowak rynowak requested review from a team as code owners December 20, 2024 18:24
This change moves the shared host package and diagnostics services to the new `pkg/components` folder. Also simplifies and improves consistency.

As part of this work, I made changes to the configuration file for consistency. Each of these diagnostics features now has a dedicated on/off switch. Where a service name is required, it is now specific in configuration rather than hardcoded in the code.

Also made the names of configuration files consistent and reflective of their scenario. All of the configuration files used for development reflect the 'dev' terminology. All of the configuration files used for self-hosted Radius (in Kubernetes) reflect the 'self-hosted' terminology.

Signed-off-by: Ryan Nowak <[email protected]>
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 8.69565% with 21 lines in your changes missing coverage. Please review.

Project coverage is 60.08%. Comparing base (8c8a6d7) to head (38410fd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ucp/server/server.go 25.00% 4 Missing and 2 partials ⚠️
pkg/dynamicrp/server/server.go 0.00% 3 Missing and 2 partials ⚠️
pkg/components/metrics/metricsservice/service.go 0.00% 3 Missing ⚠️
pkg/components/trace/traceservice/service.go 0.00% 2 Missing ⚠️
pkg/controller/service.go 0.00% 2 Missing ⚠️
pkg/armrpc/hostoptions/env.go 0.00% 1 Missing ⚠️
...nents/metrics/metricsservice/prometheusexporter.go 0.00% 1 Missing ⚠️
pkg/components/profiler/profilerservice/service.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8160      +/-   ##
==========================================
+ Coverage   60.03%   60.08%   +0.05%     
==========================================
  Files         581      579       -2     
  Lines       38536    38504      -32     
==========================================
+ Hits        23135    23136       +1     
+ Misses      13700    13668      -32     
+ Partials     1701     1700       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rynowak rynowak temporarily deployed to functional-tests December 20, 2024 18:56 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 20, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository rynowak/radius
Commit ref f59e2e3
Unique ID func5e3298069c
Image tag pr-func5e3298069c
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func5e3298069c
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func5e3298069c
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func5e3298069c
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func5e3298069c
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func5e3298069c
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

pkg/dynamicrp/config.go Show resolved Hide resolved
@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 24, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository rynowak/radius
Commit ref 38410fd
Unique ID func81c078413b
Image tag pr-func81c078413b
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func81c078413b
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func81c078413b
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func81c078413b
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func81c078413b
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func81c078413b
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded

@rynowak rynowak merged commit c6b2fce into radius-project:main Dec 24, 2024
29 checks passed
@rynowak rynowak deleted the move-shared-services branch December 24, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants