-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert region since the issues were intermittent #8119
Conversation
Do we need the updates in #8118 if we're reverting back to us-west-2 |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any downside in keeping it as us-west-1? Having long running and functional test workflows deploy to different regions will help us reduce the blast radius of impact caused in one region, as we experienced yesterday :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8119 +/- ##
==========================================
+ Coverage 59.28% 59.30% +0.01%
==========================================
Files 580 580
Lines 38983 38983
==========================================
+ Hits 23112 23118 +6
+ Misses 14220 14216 -4
+ Partials 1651 1649 -2 ☔ View full report in Codecov by Sentry. |
Turns out this is not possible with our current setup since the validation code path is shared by both the workflows and region is hardcoded in that code. |
Description
revert tests back to us-west-2
Type of change
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: