Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert region since the issues were intermittent #8119

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

nithyatsu
Copy link
Contributor

Description

revert tests back to us-west-2

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@nithyatsu nithyatsu requested review from a team as code owners December 11, 2024 17:14
@sk593
Copy link
Contributor

sk593 commented Dec 11, 2024

Do we need the updates in #8118 if we're reverting back to us-west-2

@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 11, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository nithyatsu/radius
Commit ref a1dbf02
Unique ID func3d0e190e8f
Image tag pr-func3d0e190e8f
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func3d0e190e8f
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func3d0e190e8f
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func3d0e190e8f
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func3d0e190e8f
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func3d0e190e8f
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
❌ ucp-cloud functional test failed. Please check the logs for more details

Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any downside in keeping it as us-west-1? Having long running and functional test workflows deploy to different regions will help us reduce the blast radius of impact caused in one region, as we experienced yesterday :)

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.30%. Comparing base (f4f9f55) to head (a1dbf02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8119      +/-   ##
==========================================
+ Coverage   59.28%   59.30%   +0.01%     
==========================================
  Files         580      580              
  Lines       38983    38983              
==========================================
+ Hits        23112    23118       +6     
+ Misses      14220    14216       -4     
+ Partials     1651     1649       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kachawla
Copy link
Contributor

Is there any downside in keeping it as us-west-1? Having long running and functional test workflows deploy to different regions will help us reduce the blast radius of impact caused in one region, as we experienced yesterday :)

Turns out this is not possible with our current setup since the validation code path is shared by both the workflows and region is hardcoded in that code.

@nithyatsu nithyatsu merged commit 0ea9a61 into radius-project:main Dec 11, 2024
34 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants