Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing permissions of UCP - removing unused permissions #8080

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

ytimocin
Copy link
Contributor

@ytimocin ytimocin commented Nov 24, 2024

Description

Changing permissions of UCP - removing unused permissions.

Type of change

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@ytimocin ytimocin requested review from a team as code owners November 24, 2024 16:30
@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 24, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository ytimocin/radius
Commit ref 4957ab2
Unique ID func8b10a6d975
Image tag pr-func8b10a6d975
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func8b10a6d975
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func8b10a6d975
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func8b10a6d975
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func8b10a6d975
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func8b10a6d975
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

- '*'
verbs:
- '*'
- create
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this causes this error (an error that we have all seen before but didn't know why):

Radius release not found. Proceeding with installation.
*** Installing Radius to Kubernetes ***
Installing Radius version 8d1442d-dirty to namespace: radius-system...
*** Create workspace, group and environment for test ***
Creating workspace...
Set "kind-kind" as current workspace
Error: An unknown error was returned while testing Radius API status:
Status Code: 503
Response Headers:
  Audit-Id: 863b6ad6-02a3-4ba6-9c51-61f03dc66cf2
  Cache-Control: no-cache, private
  Content-Length: 20
  Content-Type: text/plain; charset=utf-8
  Date: Sun, 24 Nov 2024 16:36:20 GMT
  X-Content-Type-Options: nosniff
  X-Kubernetes-Pf-Flowschema-Uid: db65b004-bc64-4949-a3b2-2a0[80](https://github.com/radius-project/radius/actions/runs/11997783030/job/33443799631?pr=8080#step:18:81)1c4da00
  X-Kubernetes-Pf-Prioritylevel-Uid: fe22ed3a-e9f4-4f37-9901-d2347e099c15
Response Body:
service unavailable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logs will have the real error.

Copy link
Contributor

@kachawla kachawla Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ytimocin did you get a chance to look into the logs for error as Ryan recommended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I missed that window. It is a resource permission issue but not exactly sure which one. I will keep an eye out for this error.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 24, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository ytimocin/radius
Commit ref d4ee350
Unique ID funcc3be1ca84f
Image tag pr-funcc3be1ca84f
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc3be1ca84f
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc3be1ca84f
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcc3be1ca84f
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc3be1ca84f
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc3be1ca84f
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 24, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository ytimocin/radius
Commit ref 4d81571
Unique ID funcbe28b8e775
Image tag pr-funcbe28b8e775
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcbe28b8e775
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcbe28b8e775
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcbe28b8e775
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcbe28b8e775
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcbe28b8e775
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 24, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository ytimocin/radius
Commit ref 6423ed2
Unique ID func6eb4f15964
Image tag pr-func6eb4f15964
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func6eb4f15964
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func6eb4f15964
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func6eb4f15964
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func6eb4f15964
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func6eb4f15964
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 24, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository ytimocin/radius
Commit ref 9f6550b
Unique ID funcecd2959878
Image tag pr-funcecd2959878
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcecd2959878
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcecd2959878
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcecd2959878
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcecd2959878
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcecd2959878
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 24, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository ytimocin/radius
Commit ref 71044d1
Unique ID func4dd1fcb818
Image tag pr-func4dd1fcb818
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func4dd1fcb818
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func4dd1fcb818
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func4dd1fcb818
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func4dd1fcb818
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func4dd1fcb818
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ ucp-cloud functional test failed. Please check the logs for more details
❌ corerp-cloud functional test cancelled. Please check the logs for more details

- ucp.dev
resources:
- queuemessages
- resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ytimocin ytimocin force-pushed the ytimocin/rbac/ucp branch 2 times, most recently from b3386e6 to 3768f45 Compare November 26, 2024 21:10
@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 26, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository ytimocin/radius
Commit ref 3768f45
Unique ID func1a111aced7
Image tag pr-func1a111aced7
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1a111aced7
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1a111aced7
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1a111aced7
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func1a111aced7
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1a111aced7
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ Failed to install Radius for ucp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test failed. Please check the logs for more details

@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 26, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository ytimocin/radius
Commit ref b35b7b5
Unique ID func53056784c1
Image tag pr-func53056784c1
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func53056784c1
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func53056784c1
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func53056784c1
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func53056784c1
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func53056784c1
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@radius-functional-tests
Copy link

radius-functional-tests bot commented Nov 26, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository ytimocin/radius
Commit ref a70366b
Unique ID funcce7a04a4ca
Image tag pr-funcce7a04a4ca
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcce7a04a4ca
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcce7a04a4ca
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcce7a04a4ca
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcce7a04a4ca
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcce7a04a4ca
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
❌ ucp-cloud functional test failed. Please check the logs for more details

@ytimocin ytimocin marked this pull request as draft December 3, 2024 02:02
@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 13, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository ytimocin/radius
Commit ref 1accbb7
Unique ID func62c8f105ce
Image tag pr-func62c8f105ce
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func62c8f105ce
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func62c8f105ce
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func62c8f105ce
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func62c8f105ce
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func62c8f105ce
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.65%. Comparing base (ae40560) to head (1accbb7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8080   +/-   ##
=======================================
  Coverage   59.65%   59.65%           
=======================================
  Files         577      577           
  Lines       38573    38573           
=======================================
  Hits        23010    23010           
  Misses      13916    13916           
  Partials     1647     1647           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytimocin ytimocin marked this pull request as ready for review December 13, 2024 01:42
@ytimocin ytimocin merged commit 3383692 into radius-project:main Dec 13, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update and remove unnecessary permissions of UCP component
3 participants