updating doc to use DE from existing installation #7964

nithyatsu · 2024-09-25T19:38:34Z

Description

deployment-engine is currently a private repo. Updating contributor docs to use DE from existing installation.

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

rynowak · 2024-09-25T19:41:06Z

.vscode/launch.json

-                "KUBERNETESBICEPEXTENSIBILITYURL": "http://localhost:5017/api",
-                "RADIUSBACKENDURI": "http://localhost:9000",
-            },
-        },


Can we leave this here? It's still useful.

That gives users the choice of either:

Using the DE from a cluster

Using the DE from local source code

codecov · 2024-09-25T19:49:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.62%. Comparing base (ecd79d1) to head (9521bd7).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7964   +/-   ##
=======================================
  Coverage   60.62%   60.62%           
=======================================
  Files         534      534           
  Lines       28488    28488           
=======================================
  Hits        17271    17271           
  Misses       9701     9701           
  Partials     1516     1516

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2024-09-30T17:16:27Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`053fc7a`
Unique ID	func1aa52fd8f9
Image tag	pr-func1aa52fd8f9

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1aa52fd8f9
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1aa52fd8f9
controller test image location: ghcr.io/radius-project/dev/controller:pr-func1aa52fd8f9
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1aa52fd8f9
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Signed-off-by: nithyatsu <[email protected]>

radius-functional-tests · 2024-10-03T19:05:10Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`0cb2e2f`
Unique ID	func7055ff007b
Image tag	pr-func7055ff007b

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7055ff007b
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7055ff007b
controller test image location: ghcr.io/radius-project/dev/controller:pr-func7055ff007b
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7055ff007b
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

radius-functional-tests · 2024-10-03T20:15:22Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	nithyatsu/radius
Commit ref	`9521bd7`
Unique ID	func7f480caeed
Image tag	pr-func7f480caeed

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7f480caeed
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7f480caeed
controller test image location: ghcr.io/radius-project/dev/controller:pr-func7f480caeed
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7f480caeed
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

kachawla

Thanks for updating this @nithyatsu. Were you able validate that this setup works?

...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md

…plane/running-controlplane-locally.md Co-authored-by: Karishma Chawla <[email protected]> Signed-off-by: Nithya Subramanian <[email protected]>

nithyatsu requested review from a team as code owners September 25, 2024 19:38

rynowak reviewed Sep 25, 2024

View reviewed changes

nithyatsu temporarily deployed to functional-tests September 30, 2024 17:15 — with GitHub Actions Inactive

nithyatsu added 2 commits October 3, 2024 09:19

updating doc to use existing DE

e2160cc

Signed-off-by: nithyatsu <[email protected]>

wip

0cb2e2f

nithyatsu force-pushed the update_doc branch from 053fc7a to 0cb2e2f Compare October 3, 2024 16:22

nithyatsu temporarily deployed to functional-tests October 3, 2024 19:04 — with GitHub Actions Inactive

nithyatsu requested a review from rynowak October 3, 2024 20:13

Merge branch 'main' into update_doc

9521bd7

nithyatsu temporarily deployed to functional-tests October 3, 2024 20:14 — with GitHub Actions Inactive

kachawla reviewed Oct 4, 2024

View reviewed changes

...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md Outdated Show resolved Hide resolved

...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md Outdated Show resolved Hide resolved

nithyatsu and others added 3 commits October 14, 2024 13:52

Update docs/contributing/contributing-code/contributing-code-control-…

e85197a

…plane/running-controlplane-locally.md Co-authored-by: Karishma Chawla <[email protected]> Signed-off-by: Nithya Subramanian <[email protected]>

Update docs/contributing/contributing-code/contributing-code-control-…

bc22011

…plane/running-controlplane-locally.md Co-authored-by: Karishma Chawla <[email protected]> Signed-off-by: Nithya Subramanian <[email protected]>

Merge branch 'main' into update_doc

489772a

nithyatsu had a problem deploying to functional-tests November 13, 2024 20:53 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updating doc to use DE from existing installation #7964

updating doc to use DE from existing installation #7964

nithyatsu commented Sep 25, 2024

rynowak Sep 25, 2024

codecov bot commented Sep 25, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 30, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 3, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 3, 2024 •

edited

Loading

kachawla left a comment

updating doc to use DE from existing installation #7964

Are you sure you want to change the base?

updating doc to use DE from existing installation #7964

Conversation

nithyatsu commented Sep 25, 2024

Description

Type of change

rynowak Sep 25, 2024

Choose a reason for hiding this comment

codecov bot commented Sep 25, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Sep 30, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Oct 3, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Oct 3, 2024 • edited Loading

Radius functional test overview

Test Status

kachawla left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 25, 2024 •

edited

Loading

radius-functional-tests bot commented Sep 30, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 3, 2024 •

edited

Loading

radius-functional-tests bot commented Oct 3, 2024 •

edited

Loading