Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.38.0-rc1 #7916

Closed
wants to merge 2 commits into from
Closed

Release v0.38.0-rc1 #7916

wants to merge 2 commits into from

Conversation

willdavsmith
Copy link
Contributor

Description

  • Release v0.38.0-rc1

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

@willdavsmith
release v0.38.0-rc1
a0127ca 
Signed-off-by: willdavsmith <[email protected]>
@willdavsmith willdavsmith requested review from a team as code owners September 11, 2024 23:03
willdavsmith
willdavsmith commented Sep 11, 2024
View reviewed changes
bicepconfig.json Outdated
"radius": "br:biceptypes.azurecr.io/radius:latest",
"aws": "br:biceptypes.azurecr.io/aws:latest"
"radius": "br:biceptypes.azurecr.io/radius:v0.38.0-rc1",
"aws": "br:biceptypes.azurecr.io/aws:v0.38.0-rc1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sk593 is this the right PR to do this in? do you forsee any issues?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this doesnt get updated. the version that lives in the repo will always be latest to correspond with the latest version of radius

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we auto-generate the bicepconfig during app setup, so that's when this would get populated with a specific release version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk, removing then

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (96fb582) to head (e64f038).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7916      +/-   ##
==========================================
- Coverage   60.97%   60.96%   -0.01%     
==========================================
  Files         527      527              
  Lines       27860    27860              
==========================================
- Hits        16988    16986       -2     
- Misses       9378     9379       +1     
- Partials     1494     1495       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willdavsmith
release v0.38.0-rc1
e64f038 
Signed-off-by: willdavsmith <[email protected]>
@ytimocin ytimocin closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sk593 sk593 sk593 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willdavsmith @sk593 @ytimocin