Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx image in LR test workflow #7785

Closed
wants to merge 1 commit into from
Closed

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Aug 5, 2024

Description

Fixing issues with an old version of nginx during the LRT workflows during the publish TF test recipes step. 1.27 is the latest version released of nginx

kubectl apply -f ./deploy/tf-module-server/resources.yaml -n radius-test-tf-module-server
Warning: [azurepolicy-k8sazurev2customcontainerallow-db27d7bfaf0671f6e28a] Container image nginx:1.25 for container nginx has not been allowed.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #4277

@sk593 sk593 requested review from a team as code owners August 5, 2024 21:26
@sk593 sk593 temporarily deployed to functional-tests August 5, 2024 21:26 — with GitHub Actions Inactive
Copy link

github-actions bot commented Aug 5, 2024

Unit Tests

3 293 tests  ±0   3 287 ✅ ±0   3m 52s ⏱️ -2s
  263 suites ±0       6 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit ae14c44. ± Comparison against base commit 63490d6.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.05%. Comparing base (63490d6) to head (ae14c44).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7785   +/-   ##
=======================================
  Coverage   61.05%   61.05%           
=======================================
  Files         523      523           
  Lines       27361    27361           
=======================================
  Hits        16706    16706           
  Misses       9184     9184           
  Partials     1471     1471           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rynowak
Copy link
Contributor

rynowak commented Aug 5, 2024

Is this failing because of the version we're using? or because we're pulling it from dockerhub?

@sk593
Copy link
Contributor Author

sk593 commented Aug 5, 2024

Is this failing because of the version we're using? or because we're pulling it from dockerhub?

Based on the error output, it seems like the version is the issue. The error message is specific to the image, not to docker

@sk593 sk593 marked this pull request as draft August 6, 2024 16:08
@ytimocin
Copy link
Contributor

ytimocin commented Aug 7, 2024

Is this failing because of the version we're using? or because we're pulling it from dockerhub?

Based on the error output, it seems like the version is the issue. The error message is specific to the image, not to docker

We get these errors when we are installing radius also. I think we may need to add the images we are going to use to a list (if there is one) so that we don't see the warnings. Please see this issue: #7717. cc/ @sk593 @rynowak

@radius-functional-tests
Copy link

radius-functional-tests bot commented Aug 7, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref ae14c44
Unique ID func9feaf7a1f9
Image tag pr-func9feaf7a1f9
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func9feaf7a1f9
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func9feaf7a1f9
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func9feaf7a1f9
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func9feaf7a1f9
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ datastoresrp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@sk593
Copy link
Contributor Author

sk593 commented Aug 9, 2024

Haven't seen this being reproduced anymore. Going to close this in favor of addressing here: #7717

@sk593 sk593 closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idempotency Gap # 2: Handling of propertyTransform schema attribute
3 participants