Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing Test_TerraformRecipe_KubernetesPostgres timeout to 2m #7772

Merged

Conversation

willdavsmith
Copy link
Contributor

Description

The long-running tests seem to be failing due to a timeout on the Test_TerraformRecipe_KubernetesPostgres test. Increasing the timeout might resolve the issue.

  • Increased timeout from 50s to 120s
image

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

@willdavsmith willdavsmith requested review from a team as code owners July 29, 2024 21:23
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.13%. Comparing base (1c7b3ea) to head (5ddc609).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7772   +/-   ##
=======================================
  Coverage   61.13%   61.13%           
=======================================
  Files         520      520           
  Lines       27190    27190           
=======================================
  Hits        16622    16622           
  Misses       9102     9102           
  Partials     1466     1466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 29, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository willdavsmith/radius
Commit ref 2fdc41a
Unique ID func8241ed412b
Image tag pr-func8241ed412b
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func8241ed412b
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func8241ed412b
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func8241ed412b
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func8241ed412b
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 29, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository willdavsmith/radius
Commit ref 5ddc609
Unique ID func3a04e79306
Image tag pr-func3a04e79306
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func3a04e79306
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func3a04e79306
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func3a04e79306
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func3a04e79306
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
⌛ Starting datastoresrp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded
✅ datastoresrp-cloud functional tests succeeded

@ytimocin
Copy link
Contributor

Let's try this but I am not sure that the issue is a timeout issue. I guess we have already increased it last week or the week before that. Correct me if I am wrong @lakshmimsft. I believe it may have something to do with the CoreDNS pods in AKS. cc/ @willdavsmith

@ytimocin ytimocin merged commit 93ddbdb into radius-project:main Jul 29, 2024
26 checks passed
Reshrahim pushed a commit to Reshrahim/radius that referenced this pull request Aug 27, 2024
…adius-project#7772)

# Description

The long-running tests seem to be failing due to a timeout on the
`Test_TerraformRecipe_KubernetesPostgres` test. Increasing the timeout
might resolve the issue.

* Increased timeout from 50s to 120s

<img width="1006" alt="image"
src="https://github.com/user-attachments/assets/70e3077f-c2bb-4be2-8f51-125d96a1141d">

## Type of change

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: Reshma Abdul Rahim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants