"rad credential register aws" command changes for irsa #7750
Conversation
Signed-off-by: Vishwanath Hiremath <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7750 +/- ##
==========================================
- Coverage 61.06% 61.05% -0.01%
==========================================
Files 521 523 +2
Lines 27276 27361 +85
==========================================
+ Hits 16655 16706 +51
- Misses 9157 9184 +27
- Partials 1464 1471 +7 ☔ View full report in Codecov by Sentry. |
vishwahiremat
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
| }, | ||
| } | ||
|
|
||
| err = client.PutAWS(ctx, credential) |
There was a problem hiding this comment.
if we have access key credential configured, and run rad credential register, then we would just overwrite it, since we store exactly one credential which is "default" correct?
There was a problem hiding this comment.
LGTM. would be great if @Reshrahim / @willtsai review the ux messages and are ok with them.
There was a problem hiding this comment.
Needs a rebase with main because this workflow doesn't exist anymore. The name has changed.
Signed-off-by: Vishwanath Hiremath <[email protected]>
pkg/cli/cmd/credential/credential.go
Outdated
| rad credential register aws --access-key-id <access-key-id> --secret-access-key <secret-access-key> | ||
| # Register (Add or update) cloud provider credential for AWS with access key authentication. | ||
| rad credential register aws access-key --access-key-id <access-key-id> --secret-access-key <secret-access-key> | ||
| # Register (Add or update) cloud provider credential for AWS with IRSA. |
There was a problem hiding this comment.
| # Register (Add or update) cloud provider credential for AWS with IRSA. | |
| # Register (Add or update) cloud provider credential for AWS with IRSA (IAM Roles for Service Accounts). |
Abbreviating IRSA wherever possible in docs would be helpful for the user
Just took a look and suggested abbreviation for IRSA in couple of places. |
Signed-off-by: Vishwanath Hiremath <[email protected]>
vishwahiremat
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
| return clierrors.Message("Access Key id %q cannot be empty.", r.AccessKeyID) | ||
| } | ||
| if r.SecretAccessKey == "" { | ||
| return clierrors.Message("Secret Access Key %q cannot be empty.", r.SecretAccessKey) |
There was a problem hiding this comment.
Why do we need to print the empty AccessKey and AccessKeyID here? I mean why do we need %q here?
There was a problem hiding this comment.
this is the exisitng code for access-key type. we moved it to different file
| if err != nil { | ||
| return err | ||
| } | ||
| credential := ucp.AwsCredentialResource{ |
There was a problem hiding this comment.
nit: extra line before this
There was a problem hiding this comment.
Do we need to add any other tests here?
There was a problem hiding this comment.
we havent changed anything for the access-key type. the tests were copied from the previously added tests.
| Radius will use the provided IAM credential for all interactions with AWS. | ||
| ` + common.LongDescriptionBlurb, | ||
| Example: ` | ||
| # Register (Add or update) cloud provider credential for AWS with IAM authentication |
There was a problem hiding this comment.
We have the same information for both IRSA and Access Key. Is that right?
There was a problem hiding this comment.
updadted this documentation for ira kind
Signed-off-by: Vishwanath Hiremath <[email protected]>
vishwahiremat
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: Vishwanath Hiremath <[email protected]>
vishwahiremat
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
…t#7750) # Description Updating the existing `rad credential register aws command`: `rad credential register aws --access-key-id <access-key-id> --secret-access-key <secret-access-key>` should be replaced with `rad credential register aws access-key --access-key-id <access-key-id> --secret-access-key <secret-access-key>` `rad credential register aws irsa --iam-role <roleARN>` should be supported. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #issue_number --------- Signed-off-by: Vishwanath Hiremath <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]>
Description
Updating the existing
rad credential register aws command:rad credential register aws --access-key-id <access-key-id> --secret-access-key <secret-access-key>should be replaced withrad credential register aws access-key --access-key-id <access-key-id> --secret-access-key <secret-access-key>rad credential register aws irsa --iam-role <roleARN>should be supported.Type of change
Fixes: #issue_number