Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datamodel changes for secret support to Terraform Providers #7731

Merged

Conversation

lakshmimsft
Copy link
Contributor

@lakshmimsft lakshmimsft commented Jul 9, 2024

Description

Added datamodel updates for secret support to Terraform Providers configuration. This includes secrets in recipeConfig under specific Provider configurations and environment variables.
Pls see link to associated Design Doc

NOTE: Updates to functional tests are commented till we merge in corresponding PR in bicep repo : radius-project/bicep#751

Type of change

Fixes: #6539

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/tfsecretsdatamodel branch from 3d1cf71 to ab22cc1 Compare July 9, 2024 17:20
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.12%. Comparing base (9b9cf3b) to head (0c3a2b1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7731      +/-   ##
==========================================
+ Coverage   61.09%   61.12%   +0.02%     
==========================================
  Files         520      520              
  Lines       27164    27190      +26     
==========================================
+ Hits        16596    16620      +24     
- Misses       9102     9103       +1     
- Partials     1466     1467       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lakshmimsft lakshmimsft temporarily deployed to functional-tests July 9, 2024 17:37 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 9, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref e8f7dc9
Unique ID func4d222ccc06
Image tag pr-func4d222ccc06
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func4d222ccc06
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func4d222ccc06
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func4d222ccc06
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func4d222ccc06
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded
✅ datastoresrp functional tests succeeded

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/tfsecretsdatamodel branch from e8f7dc9 to 1bc32ad Compare July 9, 2024 18:30
@lakshmimsft lakshmimsft temporarily deployed to functional-tests July 9, 2024 18:40 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 9, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref 1bc32ad
Unique ID funcc91ef97f4b
Image tag pr-funcc91ef97f4b
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc91ef97f4b
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc91ef97f4b
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc91ef97f4b
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc91ef97f4b
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting cli functional tests...
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
❌ Test tool installation for ucp failed. Please check the logs for more details
❌ Failed to install Radius for ucp functional test. Please check the logs for more details
❌ ucp functional test failed. Please check the logs for more details
⌛ Starting ucp functional tests...
✅ ucp functional tests succeeded

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/tfsecretsdatamodel branch from 1bc32ad to 3ffbe4d Compare July 17, 2024 15:18
@lakshmimsft lakshmimsft force-pushed the lakshmimsft/tfsecretsdatamodel branch from 3ffbe4d to d5ed611 Compare July 17, 2024 15:47
@lakshmimsft lakshmimsft temporarily deployed to functional-tests July 17, 2024 15:52 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 17, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref d5ed611
Unique ID funce1fdf93bbe
Image tag pr-funce1fdf93bbe
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funce1fdf93bbe
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funce1fdf93bbe
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funce1fdf93bbe
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funce1fdf93bbe
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting cli functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

@lakshmimsft lakshmimsft changed the title [WIP] Add datamodel changes for secret support to Terraform Providers Add datamodel changes for secret support to Terraform Providers Jul 17, 2024
@lakshmimsft lakshmimsft marked this pull request as ready for review July 17, 2024 17:18
@lakshmimsft lakshmimsft requested review from a team as code owners July 17, 2024 17:18
Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lakshmimsft could you update the description with link to the API design doc corresponding to these changes?

Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lakshmimsft are typespec changes mostly pulled in from #7199 or have they diverged significantly since then?

@lakshmimsft lakshmimsft requested a review from ytimocin July 17, 2024 20:51
@lakshmimsft lakshmimsft requested a review from sk593 July 17, 2024 20:57
}

dm := map[string][]datamodel.ProviderConfigProperties{}
for k, v := range config.Terraform.Providers {
dm[k] = []datamodel.ProviderConfigProperties{}

for _, providerAdditionalProperties := range v {
var addnlProperties map[string]any
var convertedSecrets map[string]datamodel.SecretReference
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converted from what? Can we just call it tfProviderSecrets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function has been updated. pls take another look.

Comment on lines 439 to 441
// Account for possibility of nested additional properties during unmarshalling
// https://json-schema.org/understanding-json-schema/reference/object#additionalproperties
if tmpAddnlProperties, ok := addnlProperties["additionalProperties"]; ok && addnlProperties["additionalProperties"] != nil {
Copy link
Contributor

@kachawla kachawla Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we expect users to add additional properties within each provider config? Could you point me to the relevant section of the design doc for this?

Copy link
Contributor Author

@lakshmimsft lakshmimsft Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, this is not needed. function has been updated. pls take another look.

Comment on lines 453 to 462
if tmpSecret, ok := value.(map[string]*SecretReference); !ok {
return nil, v1.ErrInvalidModelConversion
} else {
propSecrets := getSecretsFromProviderProperties(tmpSecret)

// Add the secrets to the convertedSecrets map
for secretKey, secretValue := range propSecrets {
if convertedSecrets == nil {
convertedSecrets = map[string]datamodel.SecretReference{}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is getting difficult to follow with abbreviations being used which I'm sure are obvious to you while writing the code but I don't know how to interpret tmpSecret and propSecret. Can you look into making it more readable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been removed. pls take another look.

// check if additional properties contain Secrets
// get AdditionalProperties from providerAdditionalProperties excluding the 'secrets' key.
for key, value := range addnlProperties {
if key == "secrets" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we fetching it from additionalProperties instead of this explicit field assigned for secrets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed and has been removed.

pkg/corerp/api/v20231001preview/environment_conversion.go Outdated Show resolved Hide resolved
pkg/corerp/api/v20231001preview/environment_conversion.go Outdated Show resolved Hide resolved
pkg/corerp/api/v20231001preview/environment_conversion.go Outdated Show resolved Hide resolved
pkg/corerp/api/v20231001preview/environment_conversion.go Outdated Show resolved Hide resolved
pkg/corerp/api/v20231001preview/environment_conversion.go Outdated Show resolved Hide resolved
pkg/corerp/api/v20231001preview/environment_conversion.go Outdated Show resolved Hide resolved
Comment on lines 177 to 180
/*{
Name: secretName,
Type: validation.SecretStoresResource,
},*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these to be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will enable these to test functional test updates once bicep PR is merged in.

@@ -181,6 +187,7 @@ func Test_TerraformRecipe_KubernetesPostgres(t *testing.T) {
ValidateLabels(false),
validation.NewK8sPodForResource(appName, "postgres").
ValidateLabels(false),
// validation.NewK8sSecretForResourceWithResourceName(secretResourceName),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to be deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will uncomment this to test functional test updates once bicep PR is merged in.

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/tfsecretsdatamodel branch 2 times, most recently from 6888a35 to 305d9df Compare July 18, 2024 00:12
@lakshmimsft lakshmimsft force-pushed the lakshmimsft/tfsecretsdatamodel branch from 305d9df to 9f8b2d0 Compare July 18, 2024 00:39
@lakshmimsft lakshmimsft temporarily deployed to functional-tests July 18, 2024 01:20 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 18, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref 9f8b2d0
Unique ID func099f6fc8c7
Image tag pr-func099f6fc8c7
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func099f6fc8c7
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func099f6fc8c7
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func099f6fc8c7
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func099f6fc8c7
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/tfsecretsdatamodel branch 6 times, most recently from 361cfb4 to a807390 Compare July 18, 2024 15:42
@lakshmimsft lakshmimsft temporarily deployed to functional-tests July 18, 2024 15:49 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 18, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref a807390
Unique ID funce54701d75b
Image tag pr-funce54701d75b
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funce54701d75b
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funce54701d75b
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funce54701d75b
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funce54701d75b
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting cli functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/tfsecretsdatamodel branch from a807390 to 848376c Compare July 18, 2024 15:56
Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go once the functional test is uncommented

@lakshmimsft lakshmimsft temporarily deployed to functional-tests July 18, 2024 17:49 — with GitHub Actions Inactive
ytimocin
ytimocin previously approved these changes Jul 18, 2024
@@ -73,4 +78,16 @@ resource pgsapp 'Applications.Core/extenders@2023-10-01-preview' = {
}
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may need a reformat here

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 18, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref 1e50089
Unique ID func7893f3d7e4
Image tag pr-func7893f3d7e4
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7893f3d7e4
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7893f3d7e4
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func7893f3d7e4
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7893f3d7e4
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting cli functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded
❌ Test tool installation for cli failed. Please check the logs for more details
❌ Failed to install Radius for cli functional test. Please check the logs for more details
❌ cli functional test failed. Please check the logs for more details

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 18, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository lakshmimsft/radius-mainfork
Commit ref 0c3a2b1
Unique ID func03fa5bbb9e
Image tag pr-func03fa5bbb9e
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func03fa5bbb9e
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func03fa5bbb9e
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func03fa5bbb9e
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func03fa5bbb9e
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded
❌ Test tool installation for cli failed. Please check the logs for more details
❌ Failed to install Radius for cli functional test. Please check the logs for more details
❌ cli functional test failed. Please check the logs for more details
⌛ Starting cli functional tests...
✅ cli functional tests succeeded

@lakshmimsft lakshmimsft merged commit faa6d3d into radius-project:main Jul 18, 2024
17 checks passed
sk593 pushed a commit that referenced this pull request Jul 22, 2024
# Description

Added datamodel updates for secret support to Terraform Providers
configuration. This includes secrets in recipeConfig under specific
Provider configurations and environment variables.
Pls see link to associated [Design
Doc](https://github.com/radius-project/design-notes/pull/47/files)

NOTE: Updates to functional tests are commented till we merge in
corresponding PR in bicep repo :
radius-project/bicep#751


## Type of change
- This pull request fixes a bug in Radius and has an approved issue
(#6539)

Fixes: #6539
Reshrahim pushed a commit to Reshrahim/radius that referenced this pull request Aug 27, 2024
…us-project#7731)

# Description

Added datamodel updates for secret support to Terraform Providers
configuration. This includes secrets in recipeConfig under specific
Provider configurations and environment variables.
Pls see link to associated [Design
Doc](https://github.com/radius-project/design-notes/pull/47/files)

NOTE: Updates to functional tests are commented till we merge in
corresponding PR in bicep repo :
radius-project/bicep#751

## Type of change
- This pull request fixes a bug in Radius and has an approved issue
(radius-project#6539)

Fixes: radius-project#6539
Signed-off-by: Reshma Abdul Rahim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow any Terraform provider to be configured and used in a Recipe
3 participants