Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting functional tests as cloud and non-cloud #7716

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

ytimocin
Copy link
Contributor

@ytimocin ytimocin commented Jun 24, 2024

Description

The goal of this PR is to create another workflow to run functional tests that don't use cloud resources and also remove the non-cloud tests from the existing functional test workflow that requires approval. In brief:

  1. Workflow: functional-test-cloud (This requires an approval)
  2. Workflow: functional-test-noncloud (This doesn't require an approval and it should be enabled on forks)

RP tests that use cloud resources:

  • Core
  • DataStores
  • UCP

RP tests that use non-cloud resources:

  • CLI
  • Core
  • Dapr
  • DataStores
  • Kubernetes
  • Messaging
  • Samples
  • UCP

Type of change

@ytimocin ytimocin temporarily deployed to functional-tests June 24, 2024 21:29 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jun 24, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref be8b05c
Unique ID func650b94b0fb
Image tag pr-func650b94b0fb
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func650b94b0fb
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func650b94b0fb
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func650b94b0fb
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func650b94b0fb
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting cli functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
❌ Failed to install Radius for cli functional test. Please check the logs for more details
❌ Failed to install Radius for shared functional test. Please check the logs for more details
❌ Failed to install Radius for daprrp functional test. Please check the logs for more details
❌ cli functional test failed. Please check the logs for more details
❌ shared functional test failed. Please check the logs for more details
❌ Failed to install Radius for datastoresrp functional test. Please check the logs for more details
❌ daprrp functional test failed. Please check the logs for more details
❌ datastoresrp functional test failed. Please check the logs for more details
❌ Failed to install Radius for kubernetes functional test. Please check the logs for more details
❌ Failed to install Radius for ucp functional test. Please check the logs for more details
❌ kubernetes functional test cancelled. Please check the logs for more details
❌ samples functional test cancelled. Please check the logs for more details
❌ msgrp functional test cancelled. Please check the logs for more details
❌ ucp functional test cancelled. Please check the logs for more details

@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from be8b05c to 7f788b7 Compare June 24, 2024 21:35
@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from 7f788b7 to c7d47e6 Compare June 24, 2024 21:40
Copy link

github-actions bot commented Jun 24, 2024

Unit Tests

3 275 tests  ±0   3 269 ✅ ±0   3m 57s ⏱️ -1s
  261 suites ±0       6 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 9090888. ± Comparison against base commit a8f29eb.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.13%. Comparing base (a8f29eb) to head (9090888).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7716   +/-   ##
=======================================
  Coverage   61.12%   61.13%           
=======================================
  Files         520      520           
  Lines       27190    27190           
=======================================
+ Hits        16620    16622    +2     
+ Misses       9103     9102    -1     
+ Partials     1467     1466    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from c7d47e6 to ab8b940 Compare June 24, 2024 21:52
@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from ab8b940 to 8ccc61d Compare June 24, 2024 21:55
@radius-functional-tests

This comment has been minimized.

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jun 24, 2024

⌛ Building Radius and pushing container images for functional tests...

✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples-noncloud functional tests...
⌛ Starting datastoresrp-noncloud functional tests...
⌛ Starting msgrp-noncloud functional tests...
⌛ Starting kubernetes-noncloud functional tests...
⌛ Starting corerp-noncloud functional tests...
⌛ Starting daprrp-noncloud functional tests...
❌ Failed to install Radius for samples-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for msgrp-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for datastoresrp-noncloud functional test. Please check the logs for more details
❌ samples-noncloud functional test failed. Please check the logs for more details
❌ msgrp-noncloud functional test failed. Please check the logs for more details
❌ datastoresrp-noncloud functional test cancelled. Please check the logs for more details
❌ cli-noncloud functional test cancelled. Please check the logs for more details
❌ ucp-noncloud functional test cancelled. Please check the logs for more details
❌ corerp-noncloud functional test cancelled. Please check the logs for more details

@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from 8ccc61d to 399a3c3 Compare June 25, 2024 08:21
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jun 25, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 399a3c3
Unique ID func30605840d6
Image tag pr-func30605840d6
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func30605840d6
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func30605840d6
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func30605840d6
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func30605840d6
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
❌ Test tool installation for cli-noncloud failed. Please check the logs for more details
❌ Failed to install Radius for cli-noncloud functional test. Please check the logs for more details
❌ Test tool installation for datastoresrp-noncloud failed. Please check the logs for more details
❌ Failed to install Radius for datastoresrp-noncloud functional test. Please check the logs for more details
❌ Test tool installation for corerp-noncloud failed. Please check the logs for more details
❌ Failed to install Radius for corerp-noncloud functional test. Please check the logs for more details
❌ cli-noncloud functional test failed. Please check the logs for more details
❌ Test tool installation for daprrp-noncloud failed. Please check the logs for more details
❌ datastoresrp-noncloud functional test cancelled. Please check the logs for more details
❌ ucp-noncloud functional test cancelled. Please check the logs for more details
❌ kubernetes-noncloud functional test cancelled. Please check the logs for more details
❌ corerp-noncloud functional test cancelled. Please check the logs for more details
❌ daprrp-noncloud functional test cancelled. Please check the logs for more details
❌ samples-noncloud functional test cancelled. Please check the logs for more details

@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from 399a3c3 to afefa5b Compare June 25, 2024 08:28
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jun 25, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref afefa5b
Unique ID func954c0d57ca
Image tag pr-func954c0d57ca
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func954c0d57ca
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func954c0d57ca
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func954c0d57ca
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func954c0d57ca
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp-noncloud functional tests...
⌛ Starting corerp-noncloud functional tests...
⌛ Starting kubernetes-noncloud functional tests...
⌛ Starting datastoresrp-noncloud functional tests...
⌛ Starting cli-noncloud functional tests...
⌛ Starting ucp-noncloud functional tests...
⌛ Starting samples-noncloud functional tests...
❌ Failed to install Radius for msgrp-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for daprrp-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for datastoresrp-noncloud functional test. Please check the logs for more details
❌ corerp-noncloud functional test failed. Please check the logs for more details
❌ msgrp-noncloud functional test failed. Please check the logs for more details
❌ daprrp-noncloud functional test failed. Please check the logs for more details
❌ datastoresrp-noncloud functional test failed. Please check the logs for more details
❌ datastoresrp-noncloud functional test cancelled. Please check the logs for more details
❌ cli-noncloud functional test cancelled. Please check the logs for more details
❌ kubernetes-noncloud functional test cancelled. Please check the logs for more details
❌ ucp-noncloud functional test cancelled. Please check the logs for more details
❌ samples-noncloud functional test cancelled. Please check the logs for more details

@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from afefa5b to 273fd42 Compare June 25, 2024 12:10
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jun 25, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 273fd42
Unique ID func5f94de1897
Image tag pr-func5f94de1897
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func5f94de1897
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func5f94de1897
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func5f94de1897
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func5f94de1897
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp-noncloud functional tests...
⌛ Starting cli-noncloud functional tests...
⌛ Starting daprrp-noncloud functional tests...
⌛ Starting corerp-noncloud functional tests...
⌛ Starting datastoresrp-noncloud functional tests...
⌛ Starting kubernetes-noncloud functional tests...
⌛ Starting samples-noncloud functional tests...
❌ Failed to install Radius for cli-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for daprrp-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for datastoresrp-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for ucp-noncloud functional test. Please check the logs for more details
❌ msgrp-noncloud functional test failed. Please check the logs for more details
❌ daprrp-noncloud functional test failed. Please check the logs for more details
❌ datastoresrp-noncloud functional test cancelled. Please check the logs for more details
❌ corerp-noncloud functional test cancelled. Please check the logs for more details
❌ kubernetes-noncloud functional test cancelled. Please check the logs for more details
❌ samples-noncloud functional test cancelled. Please check the logs for more details

@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from 273fd42 to e6aa7c0 Compare June 25, 2024 12:47
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jun 25, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref e6aa7c0
Unique ID func9e6c54c190
Image tag pr-func9e6c54c190
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func9e6c54c190
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func9e6c54c190
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func9e6c54c190
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func9e6c54c190
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp-noncloud functional tests...
⌛ Starting kubernetes-noncloud functional tests...
⌛ Starting samples-noncloud functional tests...
⌛ Starting msgrp-noncloud functional tests...
⌛ Starting corerp-noncloud functional tests...
⌛ Starting cli-noncloud functional tests...
⌛ Starting ucp-noncloud functional tests...
❌ Failed to install Radius for datastoresrp-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for msgrp-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for kubernetes-noncloud functional test. Please check the logs for more details
❌ msgrp-noncloud functional test failed. Please check the logs for more details
❌ daprrp-noncloud functional test cancelled. Please check the logs for more details
❌ kubernetes-noncloud functional test cancelled. Please check the logs for more details
❌ samples-noncloud functional test cancelled. Please check the logs for more details
❌ cli-noncloud functional test cancelled. Please check the logs for more details
❌ corerp-noncloud functional test cancelled. Please check the logs for more details
❌ ucp-noncloud functional test cancelled. Please check the logs for more details

@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from e6aa7c0 to 530192c Compare June 25, 2024 13:09
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jun 25, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 530192c
Unique ID funcdf250d8c13
Image tag pr-funcdf250d8c13
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcdf250d8c13
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcdf250d8c13
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcdf250d8c13
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcdf250d8c13
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples-noncloud functional tests...
⌛ Starting msgrp-noncloud functional tests...
⌛ Starting daprrp-noncloud functional tests...
⌛ Starting cli-noncloud functional tests...
⌛ Starting corerp-noncloud functional tests...
⌛ Starting ucp-noncloud functional tests...
⌛ Starting kubernetes-noncloud functional tests...
❌ Failed to install Radius for samples-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for datastoresrp-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for cli-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for daprrp-noncloud functional test. Please check the logs for more details
❌ Failed to install Radius for corerp-noncloud functional test. Please check the logs for more details
❌ samples-noncloud functional test failed. Please check the logs for more details
❌ datastoresrp-noncloud functional test failed. Please check the logs for more details
❌ cli-noncloud functional test failed. Please check the logs for more details
❌ daprrp-noncloud functional test failed. Please check the logs for more details
❌ corerp-noncloud functional test cancelled. Please check the logs for more details
❌ msgrp-noncloud functional test cancelled. Please check the logs for more details
❌ kubernetes-noncloud functional test cancelled. Please check the logs for more details
❌ ucp-noncloud functional test cancelled. Please check the logs for more details

- role: control-plane
extraMounts:
- containerPath: "/etc/containerd/certs.d/${{ inputs.registry-name }}"
hostPath: "$TEMP_CERT_DIR/certs/${{ inputs.registry-server }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still using the environment variable. Can you update it please?

description: "Whether the KinD cluster should be created with a secure local registry configuration"
required: false
default: "false"
temp-cert-dir:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: cert-dir. Saying "temp" doesn't really make sense as a parameter name. I think it's a translation from the original code.

@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from 450c48b to 9e23ddf Compare July 19, 2024 23:37
@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from 9e23ddf to 84ff1c2 Compare July 19, 2024 23:51
@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from 84ff1c2 to 7995e48 Compare July 20, 2024 00:03
@ytimocin ytimocin temporarily deployed to functional-tests July 20, 2024 00:03 — with GitHub Actions Inactive
rynowak
rynowak previously approved these changes Jul 20, 2024
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 20, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 7995e48
Unique ID func83d86a5209
Image tag pr-func83d86a5209
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func83d86a5209
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func83d86a5209
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func83d86a5209
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func83d86a5209
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting cli functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
❌ shared functional test failed. Please check the logs for more details
❌ datastoresrp functional test cancelled. Please check the logs for more details
❌ samples functional test cancelled. Please check the logs for more details
❌ cli functional test cancelled. Please check the logs for more details
❌ ucp functional test cancelled. Please check the logs for more details

@radius-functional-tests
Copy link

radius-functional-tests bot commented Jul 20, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 014a93d
Unique ID func8a54a8c501
Image tag pr-func8a54a8c501
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func8a54a8c501
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func8a54a8c501
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func8a54a8c501
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func8a54a8c501
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting cli functional tests...
❌ shared functional test failed. Please check the logs for more details
✅ msgrp functional tests succeeded
❌ samples functional test cancelled. Please check the logs for more details
❌ kubernetes functional test cancelled. Please check the logs for more details
❌ daprrp functional test cancelled. Please check the logs for more details
❌ datastoresrp functional test cancelled. Please check the logs for more details
❌ cli functional test cancelled. Please check the logs for more details

@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from 014a93d to f7944c9 Compare July 22, 2024 18:11
@ytimocin ytimocin force-pushed the ytimocin/splitCloudNonCloud branch from f7944c9 to 9090888 Compare July 22, 2024 18:28
Copy link
Contributor

@sylvainsf sylvainsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ytimocin ytimocin merged commit 46bf036 into main Jul 22, 2024
27 of 28 checks passed
@ytimocin ytimocin deleted the ytimocin/splitCloudNonCloud branch July 22, 2024 18:54
ytimocin added a commit to ytimocin/radius that referenced this pull request Jul 22, 2024
The goal of this PR is to create another workflow to run functional
tests that don't use cloud resources and also remove the non-cloud tests
from the existing functional test workflow that requires approval. In
brief:

1. Workflow: **functional-test-cloud** (This requires an approval)
2. Workflow: **functional-test-noncloud** (This doesn't require an
approval and it should be enabled on forks)

**RP tests that use cloud resources:**
* Core
* DataStores
* UCP

**RP tests that use non-cloud resources:**
* CLI
* Core
* Dapr
* DataStores
* Kubernetes
* Messaging
* Samples
* UCP

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
Fixes: radius-project#7624

---------

Signed-off-by: ytimocin <[email protected]>
sk593 pushed a commit that referenced this pull request Jul 22, 2024
The goal of this PR is to create another workflow to run functional
tests that don't use cloud resources and also remove the non-cloud tests
from the existing functional test workflow that requires approval. In
brief:

1. Workflow: **functional-test-cloud** (This requires an approval)
2. Workflow: **functional-test-noncloud** (This doesn't require an
approval and it should be enabled on forks)

**RP tests that use cloud resources:**
* Core
* DataStores
* UCP

**RP tests that use non-cloud resources:**
* CLI
* Core
* Dapr
* DataStores
* Kubernetes
* Messaging
* Samples
* UCP

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
Fixes: #7624

---------

Signed-off-by: ytimocin <[email protected]>
Reshrahim pushed a commit to Reshrahim/radius that referenced this pull request Aug 27, 2024
# Description

The goal of this PR is to create another workflow to run functional
tests that don't use cloud resources and also remove the non-cloud tests
from the existing functional test workflow that requires approval. In
brief:

1. Workflow: **functional-test-cloud** (This requires an approval)
2. Workflow: **functional-test-noncloud** (This doesn't require an
approval and it should be enabled on forks)

**RP tests that use cloud resources:**
* Core
* DataStores
* UCP

**RP tests that use non-cloud resources:**
* CLI
* Core
* Dapr
* DataStores
* Kubernetes
* Messaging
* Samples
* UCP

## Type of change
- This pull request adds or changes features of Radius and has an
approved issue (issue link required).
Fixes: radius-project#7624

---------

Signed-off-by: ytimocin <[email protected]>
Signed-off-by: Reshma Abdul Rahim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github workflow changes to not require approval for non-cloud tests
5 participants