-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting functional tests as cloud and non-cloud #7716
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
be8b05c
to
7f788b7
Compare
7f788b7
to
c7d47e6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7716 +/- ##
=======================================
Coverage 61.12% 61.13%
=======================================
Files 520 520
Lines 27190 27190
=======================================
+ Hits 16620 16622 +2
+ Misses 9103 9102 -1
+ Partials 1467 1466 -1 ☔ View full report in Codecov by Sentry. |
c7d47e6
to
ab8b940
Compare
ab8b940
to
8ccc61d
Compare
This comment has been minimized.
This comment has been minimized.
⌛ Building Radius and pushing container images for functional tests... ✅ Container images build succeeded |
8ccc61d
to
399a3c3
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
399a3c3
to
afefa5b
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
afefa5b
to
273fd42
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
273fd42
to
e6aa7c0
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
e6aa7c0
to
530192c
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
- role: control-plane | ||
extraMounts: | ||
- containerPath: "/etc/containerd/certs.d/${{ inputs.registry-name }}" | ||
hostPath: "$TEMP_CERT_DIR/certs/${{ inputs.registry-server }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still using the environment variable. Can you update it please?
description: "Whether the KinD cluster should be created with a secure local registry configuration" | ||
required: false | ||
default: "false" | ||
temp-cert-dir: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: cert-dir
. Saying "temp" doesn't really make sense as a parameter name. I think it's a translation from the original code.
450c48b
to
9e23ddf
Compare
9e23ddf
to
84ff1c2
Compare
84ff1c2
to
7995e48
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
7995e48
to
014a93d
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
014a93d
to
f7944c9
Compare
Signed-off-by: ytimocin <[email protected]>
Signed-off-by: ytimocin <[email protected]>
Signed-off-by: ytimocin <[email protected]>
Signed-off-by: ytimocin <[email protected]>
Signed-off-by: ytimocin <[email protected]>
f7944c9
to
9090888
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
The goal of this PR is to create another workflow to run functional tests that don't use cloud resources and also remove the non-cloud tests from the existing functional test workflow that requires approval. In brief: 1. Workflow: **functional-test-cloud** (This requires an approval) 2. Workflow: **functional-test-noncloud** (This doesn't require an approval and it should be enabled on forks) **RP tests that use cloud resources:** * Core * DataStores * UCP **RP tests that use non-cloud resources:** * CLI * Core * Dapr * DataStores * Kubernetes * Messaging * Samples * UCP - This pull request adds or changes features of Radius and has an approved issue (issue link required). Fixes: radius-project#7624 --------- Signed-off-by: ytimocin <[email protected]>
The goal of this PR is to create another workflow to run functional tests that don't use cloud resources and also remove the non-cloud tests from the existing functional test workflow that requires approval. In brief: 1. Workflow: **functional-test-cloud** (This requires an approval) 2. Workflow: **functional-test-noncloud** (This doesn't require an approval and it should be enabled on forks) **RP tests that use cloud resources:** * Core * DataStores * UCP **RP tests that use non-cloud resources:** * CLI * Core * Dapr * DataStores * Kubernetes * Messaging * Samples * UCP - This pull request adds or changes features of Radius and has an approved issue (issue link required). Fixes: #7624 --------- Signed-off-by: ytimocin <[email protected]>
# Description The goal of this PR is to create another workflow to run functional tests that don't use cloud resources and also remove the non-cloud tests from the existing functional test workflow that requires approval. In brief: 1. Workflow: **functional-test-cloud** (This requires an approval) 2. Workflow: **functional-test-noncloud** (This doesn't require an approval and it should be enabled on forks) **RP tests that use cloud resources:** * Core * DataStores * UCP **RP tests that use non-cloud resources:** * CLI * Core * Dapr * DataStores * Kubernetes * Messaging * Samples * UCP ## Type of change - This pull request adds or changes features of Radius and has an approved issue (issue link required). Fixes: radius-project#7624 --------- Signed-off-by: ytimocin <[email protected]> Signed-off-by: Reshma Abdul Rahim <[email protected]>
Description
The goal of this PR is to create another workflow to run functional tests that don't use cloud resources and also remove the non-cloud tests from the existing functional test workflow that requires approval. In brief:
RP tests that use cloud resources:
RP tests that use non-cloud resources:
Type of change
Fixes: github workflow changes to not require approval for non-cloud tests #7624