Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding comments for user-defined-types #7699

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Adding comments for user-defined-types #7699

merged 1 commit into from
Jun 20, 2024

Conversation

rynowak
Copy link
Contributor

@rynowak rynowak commented Jun 19, 2024 •
edited
Loading

Description

This commit adds new commands and capabilities for working with user-defined-types in the CLI.

Some new commands:

  • rad resourceprovider *: CRUDL lifecycle management for a resource provider.
  • rad resourceprovider new: Scaffolding a template for a resource provider.
  • rad resourcetype [show|list]: RL lifecycle management for resource types (read-only).
  • rad resource create: CU lifecycle management for any resource type.

Also updated rad resource delete and similar commands to work with user-defined-types. Many commands validate a fixed list of resource types, this update allows commands to work with an arbitrary resource type.

Type of change

  • This pull request adds or changes features of Radius and has an approved issue (issue link required).

Part of: #6688

@rynowak rynowak requested review from a team as code owners June 19, 2024 20:37
ytimocin
ytimocin reviewed Jun 19, 2024
View reviewed changes
Copy link
Contributor

@ytimocin ytimocin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions to Radius CLI 🚀

cmd/rad/cmd/root.go Show resolved Hide resolved
pkg/cli/clients/clients.go Outdated Show resolved Hide resolved
pkg/cli/clients/management.go Outdated Show resolved Hide resolved
pkg/cli/cmd/resource/create/create.go Outdated Show resolved Hide resolved
pkg/cli/cmd/resource/create/create.go Outdated Show resolved Hide resolved
pkg/cli/cmd/resourceprovider/delete/delete.go Outdated Show resolved Hide resolved
pkg/cli/cmd/resourceprovider/new/new.go Show resolved Hide resolved
pkg/cli/cmd/resourceprovider/new/new.go Show resolved Hide resolved
pkg/cli/cmd/resourcetype/common/resourcetype.go Show resolved Hide resolved
pkg/cli/cmd/resourcetype/show/show.go Outdated Show resolved Hide resolved
@rynowak
Adding comments for user-defined-types
03ddd4a 
This commit adds new commands and capabilities for working with user-defined-types in the CLI.

Some new commands:

- `rad resourceprovider *`: CRUDL lifecycle management for a resource provider.
- `rad resourceprovider new`: Scaffolding a template for a resource provider.
- `rad resourcetype [show|list]`: RL lifecycle management for resource types (read-only).
- `rad resource create`: CU lifecycle management for any resource type.

Also updated `rad resource delete` and similar commands to work with user-defined-types. Many commands validate a fixed list of resource types, this update allows commands to work with an arbitrary resource type.

Signed-off-by: Ryan Nowak <[email protected]>
@rynowak
Copy link
Contributor Author

rynowak commented Jun 20, 2024

@ytimocin - updated

@rynowak rynowak temporarily deployed to functional-tests June 20, 2024 16:08 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jun 20, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository rynowak/radius
Commit ref 03ddd4a
Unique ID funce2dce5e87e
Image tag pr-funce2dce5e87e
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funce2dce5e87e
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funce2dce5e87e
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funce2dce5e87e
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funce2dce5e87e
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
✅ shared functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded

@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 80.07246% with 110 lines in your changes missing coverage. Please review.

Please upload report for BASE (features/udt@4b428bf). Learn more about missing BASE report.

Files Patch % Lines
pkg/cli/clients/management.go 52.38% 15 Missing and 15 partials ⚠️
pkg/cli/cmd/resourceprovider/delete/delete.go 72.41% 8 Missing and 8 partials ⚠️
pkg/cli/cmd/resourceprovider/new/new.go 81.57% 9 Missing and 5 partials ⚠️
pkg/cli/cmd/resource/create/create.go 87.69% 4 Missing and 4 partials ⚠️
pkg/cli/cmd/resourceprovider/create/create.go 87.30% 4 Missing and 4 partials ⚠️
pkg/cli/cmd/resourceprovider/list/list.go 80.95% 4 Missing and 4 partials ⚠️
pkg/cli/cmd/resourceprovider/show/show.go 80.95% 4 Missing and 4 partials ⚠️
pkg/cli/cmd/resourcetype/list/list.go 82.22% 4 Missing and 4 partials ⚠️
pkg/cli/cmd/resourcetype/show/show.go 84.90% 4 Missing and 4 partials ⚠️
pkg/cli/cmd/resource/delete/delete.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##             features/udt    #7699   +/-   ##
===============================================
  Coverage                ?   61.47%           
===============================================
  Files                   ?      538           
  Lines                   ?    27959           
  Branches                ?        0           
===============================================
  Hits                    ?    17187           
  Misses                  ?     9245           
  Partials                ?     1527

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rynowak rynowak merged commit 06bbfb9 into radius-project:features/udt Jun 20, 2024
13 checks passed
@rynowak rynowak deleted the udt-cli branch June 20, 2024 20:24
rynowak added a commit that referenced this pull request Jun 24, 2024
@rynowak
Adding comments for user-defined-types (#7699)
ef8511a 
# Description

This commit adds new commands and capabilities for working with
user-defined-types in the CLI.

Some new commands:

- `rad resourceprovider *`: CRUDL lifecycle management for a resource
provider.
- `rad resourceprovider new`: Scaffolding a template for a resource
provider.
- `rad resourcetype [show|list]`: RL lifecycle management for resource
types (read-only).
- `rad resource create`: CU lifecycle management for any resource type.

Also updated `rad resource delete` and similar commands to work with
user-defined-types. Many commands validate a fixed list of resource
types, this update allows commands to work with an arbitrary resource
type.

## Type of change

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).


Part of: #6688

Signed-off-by: Ryan Nowak <[email protected]>
rynowak added a commit that referenced this pull request Jun 25, 2024
@rynowak
Adding commands for user-defined-types (#7699)
6f2bf21 
This commit adds new commands and capabilities for working with
user-defined-types in the CLI.

Some new commands:

- `rad resourceprovider *`: CRUDL lifecycle management for a resource
provider.
- `rad resourceprovider new`: Scaffolding a template for a resource
provider.
- `rad resourcetype [show|list]`: RL lifecycle management for resource
types (read-only).
- `rad resource create`: CU lifecycle management for any resource type.

Also updated `rad resource delete` and similar commands to work with
user-defined-types. Many commands validate a fixed list of resource
types, this update allows commands to work with an arbitrary resource
type.

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).

Part of: #6688

Signed-off-by: Ryan Nowak <[email protected]>
rynowak added a commit to rynowak/radius that referenced this pull request Oct 31, 2024
@rynowak
Adding commands for user-defined-types (radius-project#7699)
c166319 
This commit adds new commands and capabilities for working with
user-defined-types in the CLI.

Some new commands:

- `rad resourceprovider *`: CRUDL lifecycle management for a resource
provider.
- `rad resourceprovider new`: Scaffolding a template for a resource
provider.
- `rad resourcetype [show|list]`: RL lifecycle management for resource
types (read-only).
- `rad resource create`: CU lifecycle management for any resource type.

Also updated `rad resource delete` and similar commands to work with
user-defined-types. Many commands validate a fixed list of resource
types, this update allows commands to work with an arbitrary resource
type.

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).

Part of: radius-project#6688

Signed-off-by: Ryan Nowak <[email protected]>
rynowak added a commit to rynowak/radius that referenced this pull request Oct 31, 2024
@rynowak
Adding commands for user-defined-types (radius-project#7699)
3a74917 
This commit adds new commands and capabilities for working with
user-defined-types in the CLI.

Some new commands:

- `rad resourceprovider *`: CRUDL lifecycle management for a resource
provider.
- `rad resourceprovider new`: Scaffolding a template for a resource
provider.
- `rad resourcetype [show|list]`: RL lifecycle management for resource
types (read-only).
- `rad resource create`: CU lifecycle management for any resource type.

Also updated `rad resource delete` and similar commands to work with
user-defined-types. Many commands validate a fixed list of resource
types, this update allows commands to work with an arbitrary resource
type.

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).

Part of: radius-project#6688

Signed-off-by: Ryan Nowak <[email protected]>
rynowak added a commit to rynowak/radius that referenced this pull request Nov 4, 2024
@rynowak
Adding commands for user-defined-types (radius-project#7699)
630ffa6 
This commit adds new commands and capabilities for working with
user-defined-types in the CLI.

Some new commands:

- `rad resourceprovider *`: CRUDL lifecycle management for a resource
provider.
- `rad resourceprovider new`: Scaffolding a template for a resource
provider.
- `rad resourcetype [show|list]`: RL lifecycle management for resource
types (read-only).
- `rad resource create`: CU lifecycle management for any resource type.

Also updated `rad resource delete` and similar commands to work with
user-defined-types. Many commands validate a fixed list of resource
types, this update allows commands to work with an arbitrary resource
type.

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).

Part of: radius-project#6688

Signed-off-by: Ryan Nowak <[email protected]>
rynowak added a commit to rynowak/radius that referenced this pull request Nov 5, 2024
@rynowak
Adding commands for user-defined-types (radius-project#7699)
5e488af 
This commit adds new commands and capabilities for working with
user-defined-types in the CLI.

Some new commands:

- `rad resourceprovider *`: CRUDL lifecycle management for a resource
provider.
- `rad resourceprovider new`: Scaffolding a template for a resource
provider.
- `rad resourcetype [show|list]`: RL lifecycle management for resource
types (read-only).
- `rad resource create`: CU lifecycle management for any resource type.

Also updated `rad resource delete` and similar commands to work with
user-defined-types. Many commands validate a fixed list of resource
types, this update allows commands to work with an arbitrary resource
type.

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).

Part of: radius-project#6688

Signed-off-by: Ryan Nowak <[email protected]>
rynowak added a commit to rynowak/radius that referenced this pull request Nov 11, 2024
@rynowak
Adding commands for user-defined-types (radius-project#7699)
1c78091 
This commit adds new commands and capabilities for working with
user-defined-types in the CLI.

Some new commands:

- `rad resourceprovider *`: CRUDL lifecycle management for a resource
provider.
- `rad resourceprovider new`: Scaffolding a template for a resource
provider.
- `rad resourcetype [show|list]`: RL lifecycle management for resource
types (read-only).
- `rad resource create`: CU lifecycle management for any resource type.

Also updated `rad resource delete` and similar commands to work with
user-defined-types. Many commands validate a fixed list of resource
types, this update allows commands to work with an arbitrary resource
type.

- This pull request adds or changes features of Radius and has an
approved issue (issue link required).

Part of: radius-project#6688

Signed-off-by: Ryan Nowak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reshrahim Reshrahim Reshrahim left review comments

@ytimocin ytimocin ytimocin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rynowak @ytimocin @Reshrahim