-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bicep compiler merge #7662
Merged
Merged
Bicep compiler merge #7662
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ba08cad
Update bicep generator to use bicep-types and new contract (#7506)
sk593 dbfb23c
Update rad bicep download to use official bicep compiler (#7663)
sk593 320d6f4
Update build workflow to publish bicep types to ACR (#7693)
sk593 4a3d8eb
Update release workflow to push AWS types (#7733)
sk593 37ad8cb
Update rad init to generate bicep config (#7664)
sk593 7a79210
Update validate bicep workflow (#7702)
sk593 8d313c4
Update functional test workflow with test Bicep types (#7730)
sk593 0fe9466
Update location property flags in type generator (#7784)
sk593 082564e
nit comments
sk593 06f838a
add az login
sk593 9016e04
nit
sk593 bce1d07
remove rel version overwrite
sk593 54f968d
update func test message
sk593 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ vendor/ | |
# Radius scaffolding | ||
app.bicep | ||
.rad/ | ||
bicepconfig.json | ||
|
||
# Build Output | ||
bin/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
[submodule "bicep-types"] | ||
path = bicep-types | ||
url = https://github.com/Azure/bicep-types |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule bicep-types
added at
cd259b
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
{ | ||
"experimentalFeaturesEnabled": { | ||
"extensibility": true, | ||
"extensionRegistry": true, | ||
"dynamicTypeLoading": true | ||
}, | ||
"extensions": { | ||
"radius": "br:biceptypes.azurecr.io/radius:latest", | ||
"aws": "br:biceptypes.azurecr.io/aws:latest" | ||
}, | ||
"cloud": { | ||
"credentialPrecedence": ["Environment"] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can make
Publish Bicep Types
an action by itself and call it from these workflows that you have changed in this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I was looking into that but the steps are not universal to each workflow. So it'd need a little more thought as to which parts go into the action vs are unique to each workflow. I'll add this as a possible cleanup task on the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we created a follow-up issue for this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not as a Github issue since there isn't a Github epic for this work. Once this gets merged I'll open an issue so there's a reference point