Add permission to build workflow for codecov #7432

youngbupark · 2024-04-02T23:02:59Z

Description

This is to enable to use GitHub App token in workflow for codecov.

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Signed-off-by: Young Bu Park <[email protected]>

codecov · 2024-04-02T23:15:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.83%. Comparing base (186994d) to head (7ae3e1a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7432      +/-   ##
==========================================
+ Coverage   63.81%   63.83%   +0.02%     
==========================================
  Files         416      416              
  Lines       23440    23440              
==========================================
+ Hits        14958    14964       +6     
+ Misses       7223     7220       -3     
+ Partials     1259     1256       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Young Bu Park <[email protected]>

radius-functional-tests · 2024-04-03T01:00:36Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`8b7fc72`
Unique ID	func310f1d73ec
Image tag	pr-func310f1d73ec

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func310f1d73ec
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func310f1d73ec
controller test image location: ghcr.io/radius-project/dev/controller:pr-func310f1d73ec
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func310f1d73ec
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting cli functional tests...
⌛ Starting msgrp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
✅ datastoresrp functional tests succeeded
❌ shared functional test failed. Please check the logs for more details
⌛ Starting shared functional tests...
✅ shared functional tests succeeded

Signed-off-by: Young Bu Park <[email protected]>

radius-functional-tests · 2024-04-03T17:52:03Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`1b2a98c`
Unique ID	func8365b2f318
Image tag	pr-func8365b2f318

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func8365b2f318
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func8365b2f318
controller test image location: ghcr.io/radius-project/dev/controller:pr-func8365b2f318
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func8365b2f318
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ cli functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

Signed-off-by: Young Bu Park <[email protected]>

github-actions · 2024-04-03T18:49:15Z

Test Results

1 files ±0 261 suites ±0 3m 28s ⏱️ -3s
3 136 tests - 1 3 129 ✅ ±0 7 💤 ±0 0 ❌ - 1
3 136 runs ±0 3 129 ✅ +1 7 💤 ±0 0 ❌ - 1

Results for commit 7ae3e1a. ± Comparison against base commit c8fa814.

This pull request removes 1 test.

TestMain

radius-functional-tests · 2024-04-03T18:51:59Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`7ae3e1a`
Unique ID	func80f8b9b01e
Image tag	pr-func80f8b9b01e

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func80f8b9b01e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func80f8b9b01e
controller test image location: ghcr.io/radius-project/dev/controller:pr-func80f8b9b01e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func80f8b9b01e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting cli functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ cli functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

youngbupark · 2024-04-03T19:13:56Z

.github/workflows/build.yaml

+  checks: write        # Required for updating check runs
+  pull-requests: write # Required for updating pull requests


these are required for test report step

add permission

1fb817e

Signed-off-by: Young Bu Park <[email protected]>

youngbupark had a problem deploying to functional-tests April 2, 2024 23:03 — with GitHub Actions Failure

youngbupark changed the title ~~[WIP] Add permission to build workflow for codecov~~ Add permission to build workflow for codecov Apr 3, 2024

Update build.yaml

8b7fc72

Signed-off-by: Young Bu Park <[email protected]>

youngbupark temporarily deployed to functional-tests April 3, 2024 00:59 — with GitHub Actions Inactive

youngbupark marked this pull request as ready for review April 3, 2024 15:07

youngbupark requested review from a team as code owners April 3, 2024 15:07

rynowak previously approved these changes Apr 3, 2024

View reviewed changes

add checks permission

da21670

Signed-off-by: Young Bu Park <[email protected]>

youngbupark dismissed rynowak’s stale review via da21670 April 3, 2024 17:46

youngbupark had a problem deploying to functional-tests April 3, 2024 17:46 — with GitHub Actions Failure

Merge branch 'main' into youngp/add-perm

1b2a98c

youngbupark temporarily deployed to functional-tests April 3, 2024 17:50 — with GitHub Actions Inactive

wip

590d484

Signed-off-by: Young Bu Park <[email protected]>

youngbupark had a problem deploying to functional-tests April 3, 2024 18:14 — with GitHub Actions Failure

update permission

8df6822

Signed-off-by: Young Bu Park <[email protected]>

youngbupark had a problem deploying to functional-tests April 3, 2024 18:34 — with GitHub Actions Failure

updated perm

7ae3e1a

Signed-off-by: Young Bu Park <[email protected]>

youngbupark temporarily deployed to functional-tests April 3, 2024 18:38 — with GitHub Actions Inactive

youngbupark commented Apr 3, 2024

View reviewed changes

rynowak approved these changes Apr 3, 2024

View reviewed changes

youngbupark merged commit c92ce94 into main Apr 3, 2024
20 checks passed

youngbupark deleted the youngp/add-perm branch April 3, 2024 19:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add permission to build workflow for codecov #7432

Add permission to build workflow for codecov #7432

youngbupark commented Apr 2, 2024 •

edited

Loading

codecov bot commented Apr 2, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 3, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 3, 2024 •

edited

Loading

github-actions bot commented Apr 3, 2024

radius-functional-tests bot commented Apr 3, 2024 •

edited

Loading

youngbupark Apr 3, 2024

		checks: write # Required for updating check runs
		pull-requests: write # Required for updating pull requests

Add permission to build workflow for codecov #7432

Add permission to build workflow for codecov #7432

Conversation

youngbupark commented Apr 2, 2024 • edited Loading

Description

Type of change

codecov bot commented Apr 2, 2024 • edited Loading

Codecov Report

radius-functional-tests bot commented Apr 3, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Apr 3, 2024 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Apr 3, 2024

Test Results

radius-functional-tests bot commented Apr 3, 2024 • edited Loading

Radius functional test overview

Test Status

youngbupark Apr 3, 2024

Choose a reason for hiding this comment

youngbupark commented Apr 2, 2024 •

edited

Loading

codecov bot commented Apr 2, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 3, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 3, 2024 •

edited

Loading

radius-functional-tests bot commented Apr 3, 2024 •

edited

Loading