-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable retry on functional test #7430
Conversation
Signed-off-by: Young Bu Park <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7430 +/- ##
==========================================
- Coverage 63.81% 63.79% -0.02%
==========================================
Files 416 416
Lines 23440 23440
==========================================
- Hits 14958 14954 -4
- Misses 7223 7225 +2
- Partials 1259 1261 +2 ☔ View full report in Codecov by Sentry. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
This reverts commit bef1134.
This reverts commit bef1134. Signed-off-by: Young Bu Park <[email protected]>
This reverts commit bef1134. # Description Reverting the changes because retrying the entire test doesn't work as expected. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #issue_number --------- Signed-off-by: Young Bu Park <[email protected]>
Description
This will not configure the aggressive retry which can hide the bug. So I set 2 retries for the first iteration.
clean up cluster
step - Based on the investigation, timeout happens by deleting resources. It is ok to skip for failure because long-running test always clean up cluster first before running functional test. (Configure Radius test workspace
to avoid the intermittent 503 failureType of change
#7174