Use workload identity in workflow #7337

youngbupark · 2024-03-15T17:19:19Z

Description

This is to use workload identity instead of secret auth for service principal.

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Signed-off-by: Young Bu Park <[email protected]>

github-actions · 2024-03-15T17:40:07Z

Test Results

3 135 tests ±0 3 128 ✅ ±0 3m 24s ⏱️ -4s
261 suites ±0 7 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 6f0ade9. ± Comparison against base commit c77088f.

♻️ This comment has been updated with latest results.

github-actions · 2024-03-15T17:40:32Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.9 %
main branch coverage: 65.9 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

Signed-off-by: Young Bu Park <[email protected]>

github-actions · 2024-03-15T19:07:04Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.9 %
main branch coverage: 65.9 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

.github/workflows/functional-test.yaml

Signed-off-by: Young Bu Park <[email protected]>

radius-functional-tests · 2024-03-18T17:11:40Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`ff63bb6`
Unique ID	c280fef42c
Image tag	pr-c280fef42c

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-c280fef42c
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-c280fef42c
controller test image location: ghcr.io/radius-project/dev/controller:pr-c280fef42c
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-c280fef42c
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ shared functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ cli functional tests succeeded

github-actions · 2024-03-18T17:17:05Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.9 %
main branch coverage: 65.9 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

Signed-off-by: Young Bu Park <[email protected]>

github-actions · 2024-03-18T18:44:38Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.9 %
main branch coverage: 65.9 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

Signed-off-by: Young Bu Park <[email protected]>

github-actions · 2024-03-18T18:59:25Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.9 %
main branch coverage: 65.9 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

Signed-off-by: Young Bu Park <[email protected]>

radius-functional-tests · 2024-03-18T19:21:08Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`60f05a2`
Unique ID	ec7e8b6857
Image tag	pr-ec7e8b6857

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-ec7e8b6857
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-ec7e8b6857
controller test image location: ghcr.io/radius-project/dev/controller:pr-ec7e8b6857
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-ec7e8b6857
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting cli functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ cli functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

github-actions · 2024-03-18T19:28:43Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.9 %
main branch coverage: 65.9 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

Signed-off-by: Young Bu Park <[email protected]>

github-actions · 2024-03-18T21:34:17Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 65.9 %
main branch coverage: 65.9 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

youngbupark · 2024-03-18T21:46:31Z

.github/workflows/build.yaml

@@ -306,6 +306,7 @@ jobs:
          mkdir -p ${{ env.ARTIFACT_DIR }}/${{ env.HELM_PACKAGE_DIR }}
          helm package ${{ env.HELM_CHARTS_DIR }} --version ${{ env.CHART_VERSION }} --app-version ${{ env.REL_VERSION }} --destination ${{ env.ARTIFACT_DIR }}/${{ env.HELM_PACKAGE_DIR }}
      # TODO: Delete this step once we use GHCR as the helm chart repo.
+      # Cannot use Workload Identity because azure federated identity doesn't accept wildcard tag version.


I cannot remove this code because we still use ACR for helm chart. I think we need to move helm chart to ghcr as soon as possible. cc/ @willdavsmith @rynowak @AaronCrawfis

radius-functional-tests · 2024-03-19T17:14:08Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	`6f0ade9`
Unique ID	7dc5f6a4ae
Image tag	pr-7dc5f6a4ae

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-7dc5f6a4ae
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-7dc5f6a4ae
controller test image location: ghcr.io/radius-project/dev/controller:pr-7dc5f6a4ae
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-7dc5f6a4ae
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting cli functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ cli functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

kachawla

Thanks for doing this @youngbupark! Could you also update this wiki to reflect the current state?

Use workload identity

69f0081

Signed-off-by: Young Bu Park <[email protected]>

youngbupark had a problem deploying to functional-tests March 15, 2024 17:19 — with GitHub Actions Failure

fix wrong tid

6df1c7b

Signed-off-by: Young Bu Park <[email protected]>

youngbupark had a problem deploying to functional-tests March 15, 2024 17:22 — with GitHub Actions Failure

use write pkg

d6c053e

Signed-off-by: Young Bu Park <[email protected]>

youngbupark had a problem deploying to functional-tests March 15, 2024 17:29 — with GitHub Actions Failure

youngbupark changed the title ~~[WIP] Use workload identity~~ Use workload identity in workload Mar 15, 2024

youngbupark marked this pull request as ready for review March 15, 2024 17:30

youngbupark requested review from a team as code owners March 15, 2024 17:30

youngbupark changed the title ~~Use workload identity in workload~~ Use workload identity in workflow Mar 15, 2024

clean up

b335af3

Signed-off-by: Young Bu Park <[email protected]>

youngbupark had a problem deploying to functional-tests March 15, 2024 18:56 — with GitHub Actions Failure

AaronCrawfis reviewed Mar 18, 2024

View reviewed changes

.github/workflows/functional-test.yaml Outdated Show resolved Hide resolved

AaronCrawfis reviewed Mar 18, 2024

View reviewed changes

.github/workflows/functional-test.yaml Outdated Show resolved Hide resolved

AaronCrawfis linked an issue Mar 18, 2024 that may be closed by this pull request

Switch GitHub Actions over to using Azure managed identities #7309

Open

fix cr

a2d43dd

Signed-off-by: Young Bu Park <[email protected]>

youngbupark had a problem deploying to functional-tests March 18, 2024 16:57 — with GitHub Actions Failure

revert subid

ff63bb6

Signed-off-by: Young Bu Park <[email protected]>

youngbupark temporarily deployed to functional-tests March 18, 2024 17:05 — with GitHub Actions Inactive

ytimocin previously approved these changes Mar 18, 2024

View reviewed changes

updated

abca66c

Signed-off-by: Young Bu Park <[email protected]>

youngbupark dismissed ytimocin’s stale review via abca66c March 18, 2024 18:33

youngbupark had a problem deploying to functional-tests March 18, 2024 18:33 — with GitHub Actions Failure

use workload

2766fe0

Signed-off-by: Young Bu Park <[email protected]>

youngbupark had a problem deploying to functional-tests March 18, 2024 18:48 — with GitHub Actions Failure

reverted

60f05a2

Signed-off-by: Young Bu Park <[email protected]>

youngbupark temporarily deployed to functional-tests March 18, 2024 19:18 — with GitHub Actions Inactive

add comment

6f0ade9

Signed-off-by: Young Bu Park <[email protected]>

youngbupark temporarily deployed to functional-tests March 18, 2024 21:23 — with GitHub Actions Inactive

youngbupark commented Mar 18, 2024

View reviewed changes

AaronCrawfis approved these changes Mar 19, 2024

View reviewed changes

youngbupark merged commit 48b5256 into main Mar 19, 2024
22 checks passed

youngbupark deleted the youngp/use-wi branch March 19, 2024 17:42

kachawla reviewed Mar 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use workload identity in workflow #7337

Use workload identity in workflow #7337

youngbupark commented Mar 15, 2024 •

edited

Loading

github-actions bot commented Mar 15, 2024 •

edited

Loading

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

radius-functional-tests bot commented Mar 18, 2024 •

edited

Loading

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

radius-functional-tests bot commented Mar 18, 2024 •

edited

Loading

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

youngbupark Mar 18, 2024

radius-functional-tests bot commented Mar 19, 2024 •

edited

Loading

kachawla left a comment

Use workload identity in workflow #7337

Use workload identity in workflow #7337

Conversation

youngbupark commented Mar 15, 2024 • edited Loading

Description

Type of change

github-actions bot commented Mar 15, 2024 • edited Loading

Test Results

github-actions bot commented Mar 15, 2024

github-actions bot commented Mar 15, 2024

radius-functional-tests bot commented Mar 18, 2024 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

radius-functional-tests bot commented Mar 18, 2024 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

youngbupark Mar 18, 2024

Choose a reason for hiding this comment

radius-functional-tests bot commented Mar 19, 2024 • edited Loading

Radius functional test overview

Test Status

kachawla left a comment

Choose a reason for hiding this comment

youngbupark commented Mar 15, 2024 •

edited

Loading

github-actions bot commented Mar 15, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 18, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 18, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 19, 2024 •

edited

Loading