Only set Functional Test Run as passing if all subtests pass #7303
Conversation
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: willdavsmith <[email protected]>
willdavsmith
force-pushed
the
willdavsmith/matrix
branch
from
70fab7a to
fb13222
Compare
| @@ -414,7 +413,7 @@ jobs: | |||
| # AZURE_OIDC_ISSUER | |||
| eval "export $(echo "${{ secrets.FUNCTEST_AZURE_OIDC_JSON }}" | jq -r 'to_entries | map("\(.key)=\(.value)") | @sh')" | |||
|
|
|||
| AUTHKEY=$(echo -n "${{ github.actor }}:${{ secrets.GH_RAD_CI_BOT_PAT }}" | base64) | |||
| AUTHKEY=$(echo -n "${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}" | base64) | |||
There was a problem hiding this comment.
Does this work? What's this token being used for? I would expect the github token to no longer be valid once the test run is over.
There was a problem hiding this comment.
I can remove this - only had it there for fork testing.
| break | ||
| elif [[ "$job_status" == "cancelled" ]]; then | ||
| echo "Found cancelled test. Setting test status to cancelled" | ||
| TEST_STATUS="cancelled" |
There was a problem hiding this comment.
Should we also have a break here?
There was a problem hiding this comment.
I added a break for the failure but not the cancelled because I think it's better to report "tests failed" instead of "tests cancelled" if both occur. If all tests pass but some are cancelled, we will still report the status as cancelled because we only set as "success" if we don't go in this conditional.
Signed-off-by: willdavsmith <[email protected]>
Signed-off-by: Will Smith <[email protected]>
willdavsmith
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Description
Note: Since we don't have a way to test this in the main repo, I tested the different paths (failed tests, cancelled tests, passing tests) manually on my fork here: willdavsmith#7
Type of change
Fixes: #6939