Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test organization for samples tests #7225

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

vinayada1
Copy link
Contributor

Description

Type of change

Fixes: Fixes part of #6588. This is a part of a multi-PR fix

@vinayada1 vinayada1 requested review from a team as code owners March 1, 2024 22:04
@vinayada1 vinayada1 temporarily deployed to functional-tests March 1, 2024 22:05 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Mar 1, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository test-org-admin/radius-main
Commit ref f001951
Unique ID a2ebf1c6f5
Image tag pr-a2ebf1c6f5
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-a2ebf1c6f5
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-a2ebf1c6f5
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-a2ebf1c6f5
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-a2ebf1c6f5
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

build/test.mk Outdated
@@ -78,8 +78,10 @@ test-functional-daprrp: ## Runs Dapr RP functional tests
test-functional-datastoresrp: ## Runs Datastores RP functional tests
CGO_ENABLED=1 $(GOTEST_TOOL) ./test/functional/datastoresrp/... -timeout ${TEST_TIMEOUT} -v -parallel 3 $(GOTEST_OPTS)

test-functional-samples: ## Runs Samples functional tests
CGO_ENABLED=1 $(GOTEST_TOOL) ./test/functional/samples/... -timeout ${TEST_TIMEOUT} -v -parallel 5 $(GOTEST_OPTS)
test-functional-samples: test-functional-samples-noncloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a description

rynowak
rynowak previously approved these changes Mar 3, 2024
Copy link
Contributor

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: - looks good. I left one minor suggestion

Signed-off-by: vinayada1 <[email protected]>
@vinayada1 vinayada1 force-pushed the test-org-new-samples branch from 7e06faf to 5dc1a05 Compare March 5, 2024 00:28
@vinayada1 vinayada1 temporarily deployed to functional-tests March 5, 2024 00:28 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Mar 5, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository test-org-admin/radius-main
Commit ref 5dc1a05
Unique ID 00d46e70e8
Image tag pr-00d46e70e8
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-00d46e70e8
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-00d46e70e8
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-00d46e70e8
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-00d46e70e8
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@vinayada1 vinayada1 merged commit 7d94855 into radius-project:main Mar 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants