Change organization for UCP tests and separate cloud/non-cloud tests #7219

vinayada1 · 2024-03-01T01:04:16Z

Description

Separate cloud/non-cloud tests
Organize the UCP tests as per test organization proposal design-notes#35. There will be more PRs that will follow to re-org the other tests.

Type of change

This pull request adds or changes features of Radius and has an approved issue (Separate out functional tests that require cloud/external resources #6588 ).

Fixes: Fixes part of #6588. This is a part of a multi-PR fix

radius-functional-tests · 2024-03-01T01:06:11Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	test-org-admin/radius-main
Commit ref	`7d6dca7`
Unique ID	912270a20e
Image tag	pr-912270a20e

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-912270a20e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-912270a20e
controller test image location: ghcr.io/radius-project/dev/controller:pr-912270a20e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-912270a20e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
❌ ucp functional test failed. Please check the logs for more details
❌ msgrp functional test cancelled. Please check the logs for more details
❌ kubernetes functional test cancelled. Please check the logs for more details
❌ datastoresrp functional test cancelled. Please check the logs for more details
❌ samples functional test cancelled. Please check the logs for more details

radius-functional-tests · 2024-03-01T01:14:48Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	test-org-admin/radius-main
Commit ref	`cd0be88`
Unique ID	7507f4bf68
Image tag	pr-7507f4bf68

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-7507f4bf68
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-7507f4bf68
controller test image location: ghcr.io/radius-project/dev/controller:pr-7507f4bf68
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-7507f4bf68
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
❌ ucp functional test failed. Please check the logs for more details
❌ datastoresrp functional test cancelled. Please check the logs for more details
❌ samples functional test cancelled. Please check the logs for more details
❌ msgrp functional test cancelled. Please check the logs for more details

radius-functional-tests · 2024-03-01T04:07:38Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	test-org-admin/radius-main
Commit ref	`cbf9bdc`
Unique ID	f677719d8a
Image tag	pr-f677719d8a

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-f677719d8a
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-f677719d8a
controller test image location: ghcr.io/radius-project/dev/controller:pr-f677719d8a
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-f677719d8a
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
❌ ucp functional test failed. Please check the logs for more details
❌ msgrp functional test cancelled. Please check the logs for more details
❌ kubernetes functional test cancelled. Please check the logs for more details
❌ samples functional test cancelled. Please check the logs for more details
❌ shared functional test cancelled. Please check the logs for more details

radius-functional-tests · 2024-03-01T18:54:50Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	test-org-admin/radius-main
Commit ref	`d7a91a8`
Unique ID	7b34d35003
Image tag	pr-7b34d35003

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-7b34d35003
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-7b34d35003
controller test image location: ghcr.io/radius-project/dev/controller:pr-7b34d35003
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-7b34d35003
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
❌ ucp functional test failed. Please check the logs for more details
❌ samples functional test cancelled. Please check the logs for more details
❌ datastoresrp functional test cancelled. Please check the logs for more details
❌ kubernetes functional test cancelled. Please check the logs for more details
❌ shared functional test cancelled. Please check the logs for more details

test/functional-portable/README.md

vinayada1 · 2024-03-01T18:56:25Z

test/functional-portable/testUtil.go

+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/


I have only moved this file to the new directory structure. No changes to the file itself.

test/functional-portable/testUtil.go

vinayada1 · 2024-03-01T21:08:48Z

build/test.mk

@@ -60,8 +60,13 @@ test-validate-cli: ## Run cli integration tests

 test-functional-all: test-functional-ucp test-functional-kubernetes test-functional-shared test-functional-msgrp test-functional-daprrp test-functional-datastoresrp test-functional-samples ## Runs all functional tests



The second commit in this branch moves the testUtil.go to test/testutil folder. Might be easier to review it separately as it is only renames of package name

radius-functional-tests · 2024-03-01T21:12:48Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	test-org-admin/radius-main
Commit ref	`b9de9e4`
Unique ID	3239927747
Image tag	pr-3239927747

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-3239927747
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-3239927747
controller test image location: ghcr.io/radius-project/dev/controller:pr-3239927747
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-3239927747
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
❌ Container images build failed
❌ Test recipe publishing failed

radius-functional-tests · 2024-03-01T21:46:17Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	test-org-admin/radius-main
Commit ref	`f56a2e7`
Unique ID	eafb14ecf3
Image tag	pr-eafb14ecf3

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-eafb14ecf3
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-eafb14ecf3
controller test image location: ghcr.io/radius-project/dev/controller:pr-eafb14ecf3
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-eafb14ecf3
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting daprrp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
❌ shared functional test failed. Please check the logs for more details
⌛ Starting shared functional tests...
✅ shared functional tests succeeded

build/test.mk

test/functional-portable/ucp/cloud/aws_credential_test.go

test/functional-portable/ucp/cloud/aws_test.go

test/functional-portable/ucp/ucptest.go

rynowak

after addressing minor feedback. I left a few comments, but overall this is a big improvement.

Signed-off-by: vinayada1 <[email protected]>

radius-functional-tests · 2024-03-05T18:25:20Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	test-org-admin/radius-main
Commit ref	`c8d2b5c`
Unique ID	41c3eb3e20
Image tag	pr-41c3eb3e20

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-41c3eb3e20
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-41c3eb3e20
controller test image location: ghcr.io/radius-project/dev/controller:pr-41c3eb3e20
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-41c3eb3e20
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

vinayada1 requested review from a team as code owners March 1, 2024 01:04

vinayada1 temporarily deployed to functional-tests March 1, 2024 01:05 — with GitHub Actions Inactive

vinayada1 force-pushed the test-org-new-ucp branch from 7d6dca7 to 467f740 Compare March 1, 2024 01:12

vinayada1 temporarily deployed to functional-tests March 1, 2024 01:14 — with GitHub Actions Inactive

vinayada1 force-pushed the test-org-new-ucp branch from cd0be88 to cbf9bdc Compare March 1, 2024 04:06

vinayada1 temporarily deployed to functional-tests March 1, 2024 04:07 — with GitHub Actions Inactive

vinayada1 force-pushed the test-org-new-ucp branch from cbf9bdc to d7a91a8 Compare March 1, 2024 18:53

vinayada1 temporarily deployed to functional-tests March 1, 2024 18:54 — with GitHub Actions Inactive

vinayada1 commented Mar 1, 2024

View reviewed changes

test/functional-portable/README.md Outdated Show resolved Hide resolved

vinayada1 commented Mar 1, 2024

View reviewed changes

youngbupark reviewed Mar 1, 2024

View reviewed changes

test/functional-portable/testUtil.go Outdated Show resolved Hide resolved

vinayada1 force-pushed the test-org-new-ucp branch from d7a91a8 to 0829f2f Compare March 1, 2024 19:08

vinayada1 commented Mar 1, 2024

View reviewed changes

vinayada1 force-pushed the test-org-new-ucp branch from 9a67788 to b9de9e4 Compare March 1, 2024 21:11

vinayada1 temporarily deployed to functional-tests March 1, 2024 21:12 — with GitHub Actions Inactive

vinayada1 force-pushed the test-org-new-ucp branch from b9de9e4 to f56a2e7 Compare March 1, 2024 21:45

vinayada1 temporarily deployed to functional-tests March 1, 2024 21:45 — with GitHub Actions Inactive

rynowak reviewed Mar 3, 2024

View reviewed changes

build/test.mk Outdated Show resolved Hide resolved

rynowak reviewed Mar 3, 2024

View reviewed changes

build/test.mk Show resolved Hide resolved

rynowak reviewed Mar 3, 2024

View reviewed changes

test/functional-portable/ucp/cloud/aws_credential_test.go Outdated Show resolved Hide resolved

rynowak reviewed Mar 3, 2024

View reviewed changes

test/functional-portable/ucp/cloud/aws_test.go Outdated Show resolved Hide resolved

rynowak reviewed Mar 3, 2024

View reviewed changes

test/functional-portable/ucp/ucptest.go Outdated Show resolved Hide resolved

rynowak previously approved these changes Mar 3, 2024

View reviewed changes

vinayada1 added 3 commits March 5, 2024 10:22

Change test organization for UCP tests

74bcd9a

Signed-off-by: vinayada1 <[email protected]>

fix comments

3f5038a

Signed-off-by: vinayada1 <[email protected]>

fix comment

c8d2b5c

Signed-off-by: vinayada1 <[email protected]>

vinayada1 dismissed rynowak’s stale review via c8d2b5c March 5, 2024 18:24

vinayada1 force-pushed the test-org-new-ucp branch from f56a2e7 to c8d2b5c Compare March 5, 2024 18:24

vinayada1 temporarily deployed to functional-tests March 5, 2024 18:24 — with GitHub Actions Inactive

rynowak approved these changes Mar 5, 2024

View reviewed changes

vinayada1 merged commit 7dd7c17 into radius-project:main Mar 5, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change organization for UCP tests and separate cloud/non-cloud tests #7219

Change organization for UCP tests and separate cloud/non-cloud tests #7219

vinayada1 commented Mar 1, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 1, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 1, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 1, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 1, 2024 •

edited

Loading

vinayada1 Mar 1, 2024

vinayada1 Mar 1, 2024

radius-functional-tests bot commented Mar 1, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 1, 2024 •

edited

Loading

rynowak left a comment

radius-functional-tests bot commented Mar 5, 2024 •

edited

Loading

		@@ -60,8 +60,13 @@ test-validate-cli: ## Run cli integration tests

		test-functional-all: test-functional-ucp test-functional-kubernetes test-functional-shared test-functional-msgrp test-functional-daprrp test-functional-datastoresrp test-functional-samples ## Runs all functional tests

Change organization for UCP tests and separate cloud/non-cloud tests #7219

Change organization for UCP tests and separate cloud/non-cloud tests #7219

Conversation

vinayada1 commented Mar 1, 2024 • edited Loading

Description

Type of change

radius-functional-tests bot commented Mar 1, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Mar 1, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Mar 1, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Mar 1, 2024 • edited Loading

Radius functional test overview

Test Status

vinayada1 Mar 1, 2024

Choose a reason for hiding this comment

vinayada1 Mar 1, 2024

Choose a reason for hiding this comment

radius-functional-tests bot commented Mar 1, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Mar 1, 2024 • edited Loading

Radius functional test overview

Test Status

rynowak left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Mar 5, 2024 • edited Loading

Radius functional test overview

Test Status

vinayada1 commented Mar 1, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 1, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 1, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 1, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 1, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 1, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 1, 2024 •

edited

Loading

radius-functional-tests bot commented Mar 5, 2024 •

edited

Loading